Back port geant4 10.7.1 changes from geant4_vecgeom

[smuzaffar]

No description provided.

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_11_3_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

Pull request #6742 was updated.

[silviodonato]

@smuzaffar do we need also https://github.com/cms-sw/cmsdist/compare/IB/CMSSW_11_3_X/geant4_vecgeom to be tested with this PR?
cc @cms-sw/simulation-l2

[civanch]

@silviodonato , this PR includes recent versions of G4, vecgeom, and clhep, which should go together. As I understand, they were validated together by PPD.

[silviodonato]

@smuzaffar @cms-sw/simulation-l2
I'm sorry I wanted to say https://github.com/cms-sw/cmssw/compare/CMSSW_11_3_GEANT4_X

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e988a2/13624/summary.html
COMMIT: b9de9ba
CMSSW: CMSSW_11_3_X_2021-03-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6742/13624/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

@@@@ ----> OK  EDM Class Transients 
>> Checking EDM Class Version for src/DataFormats/GeometryCommonDetAlgo/src/classes_def.xml in libDataFormatsGeometryCommonDetAlgo.so
>> Checking EDM Class Version for src/DataFormats/GEMRecHit/src/classes_def.xml in libDataFormatsGEMRecHit.so
@@@@ ----> OK  EDM Class Transients 
>> Checking EDM Class Version for src/DataFormats/GsfTrackReco/src/classes_def.xml in libDataFormatsGsfTrackReco.so
error: class 'CLHEP::Hep3Vector' has a different checksum for ClassVersion 10. Increment ClassVersion to 11 and assign it to checksum 3438801427
Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/CLHEP/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/slc7_amd64_gcc900/edm_checks/libDataFormatsCLHEP.so] Error 1
>> Checking EDM Class Version for src/DataFormats/HGCalReco/src/classes_def.xml in libDataFormatsHGCalReco.so
Error in : Dictionary trigger function for DataFormatsCLHEP_xr not found
@@@@ ----> OK  EDM Class Transients 


[silviodonato]

please test with cms-sw/cmssw#33231

[silviodonato]

I've closed cms-sw/cmssw#33231 and opened
cms-sw/cmssw#33234

The test are running in cms-sw/cmssw#33234

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e988a2/13636/summary.html
COMMIT: b9de9ba
CMSSW: CMSSW_11_3_X_2021-03-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6742/13636/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• #33201 @jeongeun: drop type spec and move sequence to task in CommonTools
• #32420 @mrodozov: [Do not merge] Update classversion CLHEP::Hep3Vector
• #33179 @davidlange6: Move FFTJet to JetMETCorrections/FFTJetObjects

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e988a2/13636/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e988a2/13636/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIntegrationWaitingThread had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 48637 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639935
• DQMHistoTests: Total failures: 283019
• DQMHistoTests: Total nulls: 201
• DQMHistoTests: Total successes: 2356693
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -4.527 KiB( 36 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -0.145 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 1000.0,... ): -0.145 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 10224.0 ): 0.352 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.645 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.171 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): -1.310 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 8.0 ): 2.397 KiB SiStrip/MechanicalView
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: found differences in 6 / 32 workflows

[silviodonato]

The test is ok cms-sw/cmssw#33234 (comment)

[smuzaffar]

please test with cms-sw/cmssw#33231

lets re-run tests based on a clean Ib

[silviodonato]

please abort

[silviodonato]

please test with cms-sw/cmssw#33234
(cms-sw/cmssw#33231 was closed)

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_3_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e988a2/13651/summary.html
COMMIT: b9de9ba
CMSSW: CMSSW_11_3_X_2021-03-21-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6742/13651/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 49903 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639935
• DQMHistoTests: Total failures: 286690
• DQMHistoTests: Total nulls: 212
• DQMHistoTests: Total successes: 2353011
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 46.668 KiB( 36 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.352 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 250202.181 ): -0.645 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.171 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): -1.310 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 8.0 ): 2.397 KiB SiStrip/MechanicalView
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: found differences in 12 / 36 workflows

[silviodonato]

+1
validated by PdmV (https://indico.cern.ch/event/1017601/#7-validation-report-slides-onl)