Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump of CLHEP::Hep3Vector ClassVersion needed for GEANT4 10.7.1 #33234

Merged
merged 1 commit into from Mar 22, 2021

Conversation

silviodonato
Copy link
Contributor

(see #33231)

PR description:

Bump of CLHEP::Hep3Vector ClassVersion in DataFormats/CLHEP/src/classes_def.xml
needed for the update of GEANT4 ( cms-sw/cmsdist#6742 )

PR validation:

CMSSW_11_3_0_pre3_G4VECGEOM fully validated by PdmV

@silviodonato
Copy link
Contributor Author

test parameters:

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33234/21683

  • This PR adds an extra 8KB to repository

@silviodonato
Copy link
Contributor Author

urgent
for cms-sw/cmsdist#6742

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

DataFormats/CLHEP

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-056b43/13641/summary.html
COMMIT: 722a167
CMSSW: CMSSW_11_3_X_2021-03-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33234/13641/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 48636 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2639935
  • DQMHistoTests: Total failures: 283023
  • DQMHistoTests: Total nulls: 193
  • DQMHistoTests: Total successes: 2356697
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.965 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.645 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.171 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -1.310 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): 2.397 KiB SiStrip/MechanicalView
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: found differences in 12 / 36 workflows

@smuzaffar
Copy link
Contributor

+core
should we include it for next IB

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants