New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move boost to python3 #7085
Move boost to python3 #7085
Conversation
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_0_X/master. @cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
test parameters:
|
please test |
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: /cvmfs/cms-ib.cern.ch/nweek-02687/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/CondDBPyWrappers.cc.o:(.data.rel.ro._ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerIPFN4cond5Iov_tEyRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEENS0_21default_call_policiesENS_3mpl7vector3IS6_ySE_EEEEEE[_ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerIPFN4cond5Iov_tEyRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEENS0_21default_call_policiesENS_3mpl7vector3IS6_ySE_EEEEEE]+0x30): undefined reference to `boost::python::objects::py_function_impl_base::max_arity() const' /cvmfs/cms-ib.cern.ch/nweek-02687/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/CondDBPyWrappers.cc.o:(.data.rel.ro._ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberIyN4cond5Iov_tEEENS0_21default_call_policiesENS_3mpl7vector3IvRS7_RKyEEEEEE[_ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberIyN4cond5Iov_tEEENS0_21default_call_policiesENS_3mpl7vector3IvRS7_RKyEEEEEE]+0x30): undefined reference to `boost::python::objects::py_function_impl_base::max_arity() const' /cvmfs/cms-ib.cern.ch/nweek-02687/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/CondDBPyWrappers.cc.o:(.data.rel.ro._ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEN4cond5Iov_tEEENS0_21default_call_policiesENS_3mpl7vector3IvRSD_RKSB_EEEEEE[_ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEN4cond5Iov_tEEENS0_21default_call_policiesENS_3mpl7vector3IvRSD_RKSB_EEEEEE]+0x30): undefined reference to `boost::python::objects::py_function_impl_base::max_arity() const' /cvmfs/cms-ib.cern.ch/nweek-02687/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/CondDBPyWrappers.cc.o:(.data.rel.ro._ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerIPFvP7_objectENS0_21default_call_policiesENS_3mpl7vector2IvS6_EEEEEE[_ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerIPFvP7_objectENS0_21default_call_policiesENS_3mpl7vector2IvS6_EEEEEE]+0x30): undefined reference to `boost::python::objects::py_function_impl_base::max_arity() const' /cvmfs/cms-ib.cern.ch/nweek-02687/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/CondDBPyWrappers.cc.o:(.data.rel.ro._ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberIyN4cond5Iov_tEEENS0_19return_value_policyINS0_15return_by_valueENS0_21default_call_policiesEEENS_3mpl7vector2IRyRS7_EEEEEE[_ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberIyN4cond5Iov_tEEENS0_19return_value_policyINS0_15return_by_valueENS0_21default_call_policiesEEENS_3mpl7vector2IRyRS7_EEEEEE]+0x30): more undefined references to `boost::python::objects::py_function_impl_base::max_arity() const' follow collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/libCondDBV2PyInterface.so] Error 1 Leaving library rule at src/CondCore/CondDB/plugins >> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-29-2300/src/CondCore/CondDB/test/testConditionDatabase_0.cpp >> Building binary testConditionDatabase_0 Copying tmp/slc7_amd64_gcc900/src/CondCore/CondDB/test/testConditionDatabase_0/testConditionDatabase_0 to productstore area: |
please test |
Pull request #7085 was updated. |
fyi @smuzaffar - only one unit test fails - which is fixed by making getPayloadData.py use /usr/bin/env python3. So I can make a PR to change that |
please abort |
test parameters:
|
please test |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test test_PixelBaryCentreTool had ERRORS ---> test testGetPayloadData had ERRORS Comparison SummarySummary:
|
@smuzaffar - did this not run the tests with cmssw#34298? |
hum, to answer my question - yes, the cmssw PR was used. |
|
yes it did. There are few py3 related changes needed for getPayloadData script itself |
please test |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test test_PixelBaryCentreTool had ERRORS Comparison SummarySummary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
this should be merged along with cms-sw/cmssw#34298 |
merge |
likely this will break unit tests. Trying to find out which ones.