Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move boost to python3 #7085

Merged
merged 2 commits into from Jul 6, 2021

Conversation

davidlange6
Copy link
Contributor

likely this will break unit tests. Trying to find out which ones.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bd24c/16358/summary.html
COMMIT: 9667815
CMSSW: CMSSW_12_0_X_2021-06-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7085/16358/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bd24c/16358/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bd24c/16358/git-merge-result

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02687/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/CondDBPyWrappers.cc.o:(.data.rel.ro._ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerIPFN4cond5Iov_tEyRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEENS0_21default_call_policiesENS_3mpl7vector3IS6_ySE_EEEEEE[_ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerIPFN4cond5Iov_tEyRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEENS0_21default_call_policiesENS_3mpl7vector3IS6_ySE_EEEEEE]+0x30): undefined reference to `boost::python::objects::py_function_impl_base::max_arity() const'
/cvmfs/cms-ib.cern.ch/nweek-02687/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/CondDBPyWrappers.cc.o:(.data.rel.ro._ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberIyN4cond5Iov_tEEENS0_21default_call_policiesENS_3mpl7vector3IvRS7_RKyEEEEEE[_ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberIyN4cond5Iov_tEEENS0_21default_call_policiesENS_3mpl7vector3IvRS7_RKyEEEEEE]+0x30): undefined reference to `boost::python::objects::py_function_impl_base::max_arity() const'
/cvmfs/cms-ib.cern.ch/nweek-02687/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/CondDBPyWrappers.cc.o:(.data.rel.ro._ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEN4cond5Iov_tEEENS0_21default_call_policiesENS_3mpl7vector3IvRSD_RKSB_EEEEEE[_ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEN4cond5Iov_tEEENS0_21default_call_policiesENS_3mpl7vector3IvRSD_RKSB_EEEEEE]+0x30): undefined reference to `boost::python::objects::py_function_impl_base::max_arity() const'
/cvmfs/cms-ib.cern.ch/nweek-02687/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/CondDBPyWrappers.cc.o:(.data.rel.ro._ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerIPFvP7_objectENS0_21default_call_policiesENS_3mpl7vector2IvS6_EEEEEE[_ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerIPFvP7_objectENS0_21default_call_policiesENS_3mpl7vector2IvS6_EEEEEE]+0x30): undefined reference to `boost::python::objects::py_function_impl_base::max_arity() const'
/cvmfs/cms-ib.cern.ch/nweek-02687/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/CondDBPyWrappers.cc.o:(.data.rel.ro._ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberIyN4cond5Iov_tEEENS0_19return_value_policyINS0_15return_by_valueENS0_21default_call_policiesEEENS_3mpl7vector2IRyRS7_EEEEEE[_ZTVN5boost6python7objects23caller_py_function_implINS0_6detail6callerINS3_6memberIyN4cond5Iov_tEEENS0_19return_value_policyINS0_15return_by_valueENS0_21default_call_policiesEEENS_3mpl7vector2IRyRS7_EEEEEE]+0x30): more undefined references to `boost::python::objects::py_function_impl_base::max_arity() const' follow
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc900/src/CondCore/CondDB/plugins/CondDBV2PyInterface/libCondDBV2PyInterface.so] Error 1
Leaving library rule at src/CondCore/CondDB/plugins
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-29-2300/src/CondCore/CondDB/test/testConditionDatabase_0.cpp
>> Building binary testConditionDatabase_0
Copying tmp/slc7_amd64_gcc900/src/CondCore/CondDB/test/testConditionDatabase_0/testConditionDatabase_0 to productstore area:


@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2021

Pull request #7085 was updated.

@davidlange6
Copy link
Contributor Author

fyi @smuzaffar - only one unit test fails - which is fixed by making getPayloadData.py use /usr/bin/env python3. So I can make a PR to change that

@davidlange6
Copy link
Contributor Author

please abort

@davidlange6
Copy link
Contributor Author

test parameters:

@davidlange6
Copy link
Contributor Author

please test

@davidlange6 davidlange6 changed the title Experimental - move boost to python3 Move boost to python3 Jul 1, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bd24c/16378/summary.html
COMMIT: b4dce06
CMSSW: CMSSW_12_0_X_2021-06-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7085/16378/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bd24c/16378/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bd24c/16378/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS
---> test testGetPayloadData had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785711
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785688
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@davidlange6
Copy link
Contributor Author

davidlange6 commented Jul 2, 2021

@smuzaffar - did this not run the tests with cmssw#34298?

@davidlange6
Copy link
Contributor Author

hum, to answer my question - yes, the cmssw PR was used.

@davidlange6
Copy link
Contributor Author

  File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-30-2300/bin/slc7_amd64_gcc900/getPayloadData.py", line 292
    except ValueError, e:```
    
   ah - this error is in the PY3 IB:(

@smuzaffar
Copy link
Contributor

yes it did. There are few py3 related changes needed for getPayloadData script itself

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bd24c/16404/summary.html
COMMIT: b4dce06
CMSSW: CMSSW_12_0_X_2021-07-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7085/16404/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bd24c/16404/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bd24c/16404/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785711
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2785676
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

this should be merged along with cms-sw/cmssw#34298

@qliphy
Copy link
Contributor

qliphy commented Jul 6, 2021

merge

@cmsbuild cmsbuild merged commit 81fa560 into cms-sw:IB/CMSSW_12_0_X/master Jul 6, 2021
@cmsbuild cmsbuild mentioned this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants