Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOSAM] updated gosam to 2.1.0 #7089

Merged
merged 4 commits into from Jul 2, 2021
Merged

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jul 1, 2021

Fixes #7088

  • gosam version 2.1.0
  • use new github.com sources

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar smuzaffar mentioned this pull request Jul 1, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2021

Pull request #7089 was updated.

@smuzaffar smuzaffar changed the title [GOSAM] updated gosam to version 2.1.0 with py3 [GOSAM] updated gosam to 2.1.0 and gosam-contrib to 2.0-20200904 Jul 1, 2021
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a38e9/16385/summary.html
COMMIT: e615a97
CMSSW: CMSSW_12_0_X_2021-06-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7089/16385/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

++ which gfortran
+ FC='/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/gfortran -std=legacy'
+ PLATF_CONF_OPTS='--enable-shared --enable-static'
+ ./autogen.sh --enable-shared --enable-static --prefix=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/5206150309a22db730fbd489a6ec8d73/opt/cmssw/slc7_amd64_gcc900/external/gosamcontrib/2.0-20200904-5206150309a22db730fbd489a6ec8d73 --bindir=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/5206150309a22db730fbd489a6ec8d73/opt/cmssw/slc7_amd64_gcc900/external/gosamcontrib/2.0-20200904-5206150309a22db730fbd489a6ec8d73/bin --libdir=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/5206150309a22db730fbd489a6ec8d73/opt/cmssw/slc7_amd64_gcc900/external/gosamcontrib/2.0-20200904-5206150309a22db730fbd489a6ec8d73/lib 'CXX=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/c++ -fPIC' 'CC=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/gcc -fPIC' 'FC=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/gfortran -std=legacy' 'F77=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/gfortran -std=legacy'
./autogen.sh: line 5: autoreconf: command not found
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.IKPuV5 (%build)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.IKPuV5 (%build)


@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2021

Pull request #7089 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a38e9/16387/summary.html
COMMIT: 14183a3
CMSSW: CMSSW_12_0_X_2021-07-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7089/16387/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/gosamcontrib/2.0-20200904-633f694806c313a23fcffac9ea614cbc/gosam-contrib-gosam-contrib-2.0-20200904/ninja-1.2.0'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/gosamcontrib/2.0-20200904-633f694806c313a23fcffac9ea614cbc/gosam-contrib-gosam-contrib-2.0-20200904'
make: *** [all] Error 2
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.KKHXdc (%build)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.KKHXdc (%build)


@smuzaffar smuzaffar changed the title [GOSAM] updated gosam to 2.1.0 and gosam-contrib to 2.0-20200904 [GOSAM] updated gosam to 2.1.0 Jul 1, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2021

Pull request #7089 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a38e9/16393/summary.html
COMMIT: 26899ed
CMSSW: CMSSW_12_0_X_2021-07-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7089/16393/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a38e9/16393/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a38e9/16393/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785711
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2785676
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals
comparison diffs are due to message logger

@smuzaffar smuzaffar merged commit 4885659 into IB/CMSSW_12_0_X/master Jul 2, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gosam update needed
2 participants