Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 migration: drop py2-cython and only built it for py3 #7092

Merged
merged 4 commits into from Jul 3, 2021

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/master.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbc14/16401/summary.html
COMMIT: 0d26ba4
CMSSW: CMSSW_12_0_X_2021-07-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7092/16401/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

checking for python platform... linux2
checking for python script directory... ${prefix}/lib/python2.7/site-packages
checking for python extension module directory... ${exec_prefix}/lib/python2.7/site-packages
checking for Cython >= 0.24... no
checking for pyext/yoda/core.cpp... no
configure: error: Cython is required for --enable-pyext, no pre-built core.cpp was found.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.cui5qL (%build)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope


@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

Pull request #7092 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbc14/16413/summary.html
COMMIT: 78ff19c
CMSSW: CMSSW_12_0_X_2021-07-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7092/16413/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

checking for python platform... linux2
checking for python script directory... ${prefix}/lib/python2.7/site-packages
checking for python extension module directory... ${exec_prefix}/lib/python2.7/site-packages
checking for Cython >= 0.24.0... no
checking for pyext/rivet/core.cpp... no
configure: error: Cython is required for --enable-pyext, no pre-built core.cpp was found.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.WSDUKw (%prep)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope


@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

Pull request #7092 was updated.

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = GeneratorInterface/RivetInterface

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbc14/16418/summary.html
COMMIT: 0afc3cd
CMSSW: CMSSW_12_0_X_2021-07-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7092/16418/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbc14/16418/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbc14/16418/git-merge-result

Build

I found compilation error when building:

ImportError: No module named clang.cindex
gmake: *** [tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc] Error 1
>> Compiling LCG dictionary: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/CondFormatsGBRForest_xr.cc
Entering library rule at CondFormats/GBRForest
>> Compiling  tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.


@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbc14/16425/summary.html
COMMIT: 0afc3cd
CMSSW: CMSSW_12_0_X_2021-07-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7092/16425/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbc14/16425/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbc14/16425/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS
---> test test-rivet-list had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785711
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785688
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2021

Pull request #7092 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

+externals
unit tests passed except the one which is failing in Ib

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfbc14/16435/summary.html
COMMIT: 63bd73c
CMSSW: CMSSW_12_0_X_2021-07-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7092/16435/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785924
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785901
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants