cleanup python2; use rpm macros for python versions #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test parameters:
|
|
please test |
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/master. @cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
cmsbuild
added
externals-pending
orp-pending
pending-signatures
tests-pending
tests-started
and removed
tests-pending
labels
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf436d/16481/summary.html External BuildI found compilation error when building: building 'professor2.core' extension creating build/temp.linux-x86_64-2.7 creating build/temp.linux-x86_64-2.7/pyext creating build/temp.linux-x86_64-2.7/pyext/professor2 g++ -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -fPIC -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/professor2/2.3.2-a0ca8bc7f5bf17d4ebf431d880a239d4/Professor-2.3.2/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/professor2/2.3.2-a0ca8bc7f5bf17d4ebf431d880a239d4/Professor-2.3.2/pyext/professor2 -I/usr/include/python2.7 -c pyext/professor2/core.cpp -o build/temp.linux-x86_64-2.7/pyext/professor2/core.o -std=c++11 -O3 -Wno-unused-but-set-variable -Wno-sign-compare pyext/professor2/core.cpp:6:10: fatal error: Python.h: No such file or directory 6 | #include "Python.h" | ^~~~~~~~~~ compilation terminated. error: command 'g++' failed with exit status 1 make: *** [pyext/professor2/core.so] Error 1 |
|
Pull request #7106 was updated. |
|
please test |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf436d/16495/summary.html External BuildI found compilation error when building: >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/92a46f364ad580591e8f8dcb79bd7c3a/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-92a46f364ad580591e8f8dcb79bd7c3a/src/LCG/ConnectionService/src/WebCacheControl.cpp /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/92a46f364ad580591e8f8dcb79bd7c3a/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-92a46f364ad580591e8f8dcb79bd7c3a/include/LCG -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/boost/1.75.0-734a59a983e198259b7abaa8df75138c/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/libuuid/2.34-bcolbf2/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/xerces-c/3.1.3-bcolbf2/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -fdebug-prefix-map=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir=/opt/cmssw -fdebug-prefix-map=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/92a46f364ad580591e8f8dcb79bd7c3a/opt/cmssw=/opt/cmssw -g -fPIC -MMD -MF tmp/slc7_amd64_gcc900/src/LCG/ConnectionService/src/lcg_ConnectionService/WebCacheControl.cpp.d /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/92a46f364ad580591e8f8dcb79bd7c3a/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-92a46f364ad580591e8f8dcb79bd7c3a/src/LCG/ConnectionService/src/WebCacheControl.cpp -o tmp/slc7_amd64_gcc900/src/LCG/ConnectionService/src/lcg_ConnectionService/WebCacheControl.cpp.o >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/92a46f364ad580591e8f8dcb79bd7c3a/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-92a46f364ad580591e8f8dcb79bd7c3a/src/LCG/ConnectionService/src/module.cpp /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/gcc/9.3.0/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/92a46f364ad580591e8f8dcb79bd7c3a/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-92a46f364ad580591e8f8dcb79bd7c3a/include/LCG -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/boost/1.75.0-734a59a983e198259b7abaa8df75138c/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/libuuid/2.34-bcolbf2/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/xerces-c/3.1.3-bcolbf2/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -fdebug-prefix-map=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir=/opt/cmssw -fdebug-prefix-map=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/92a46f364ad580591e8f8dcb79bd7c3a/opt/cmssw=/opt/cmssw -g -fPIC -MMD -MF tmp/slc7_amd64_gcc900/src/LCG/ConnectionService/src/lcg_ConnectionService/module.cpp.d /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/92a46f364ad580591e8f8dcb79bd7c3a/opt/cmssw/slc7_amd64_gcc900/cms/coral/CORAL_2_3_21-92a46f364ad580591e8f8dcb79bd7c3a/src/LCG/ConnectionService/src/module.cpp -o tmp/slc7_amd64_gcc900/src/LCG/ConnectionService/src/lcg_ConnectionService/module.cpp.o + '[' '' == set ']' error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.ItGTYf (%build) RPM build errors: Macro %rpmbuild_libdir defined but not used within scope Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.ItGTYf (%build) |
|
Pull request #7106 was updated. |
|
please test |
|
please test |
This was referenced Jul 8, 2021
|
please test |
1 similar comment
|
please test |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf436d/16617/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
+externals |
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
This was referenced Jul 10, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this cleanup non of the py3 packages should depend on python (directly or indirectly)