update mkfit to V3.1.0

[slava77]

related CMSSW and cms-data PR are coming.

https://github.com/trackreco/mkFit/releases/tag/V3.1.0-0%2Bpr332

@mmasciov @makortel

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

[slava77]

@cmsbuild please test workflow 11634.7

I think that the API is backward compatible. So, I wanted to test to see if synchronized merge is required.

[makortel]

I think (but haven't tested) that

-cp -a Geoms/*.so %{i}/Geoms

line could be removed, and the mkdir line be changed accordingly

-mkdir %{i}/include %{i}/include/mkFit %{i}/Geoms
+mkdir %{i}/include %{i}/include/mkFit

[cmsbuild]

Pull request #7113 was updated.

[slava77]

@cmsbuild please test

[slava77]

abort test

[slava77]

@cmsbuild please test workflow 11634.7

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4355/16579/summary.html
COMMIT: 64d0b3c
CMSSW: CMSSW_12_0_X_2021-07-07-1900/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7113/16579/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 11634.7

----- Begin Fatal Exception 08-Jul-2021 01:42:11 CEST-----------------------
An exception of category 'LogicError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmofflineOnPAT_2_step'
   [2] Prefetching for module SingleTopTChannelLeptonDQM_miniAOD/'singleTopElectronMediumDQM_miniAOD'
   [3] Prefetching for module PATMuonSlimmer/'slimmedMuons'
   [4] Prefetching for module PATMuonSelector/'selectedPatMuons'
   [5] Prefetching for module PATMuonProducer/'patMuons'
   [6] Prefetching for module MuonProducer/'muons'
   [7] Prefetching for module MuonIdProducer/'muons1stStep'
   [8] Prefetching for module DuplicateListMerger/'generalTracks'
   [9] Prefetching for module TrackProducer/'mergedDuplicateTracks'
   [10] Prefetching for module MeasurementTrackerEventProducer/'MeasurementTrackerEvent'
   [11] Prefetching for module JetCoreClusterSplitter/'siPixelClusters'
   [12] Prefetching for module PrimaryVertexProducer/'firstStepPrimaryVerticesPreSplitting'
   [13] Prefetching for module TrackProducer/'initialStepTracksPreSplitting'
   [14] Calling method for module MkFitOutputConverter/'initialStepTrackCandidatesPreSplitting'
Exception Message:
Candidate 0 from seed 66 hit 2 has different layer in candidate (45) and seed (46). Hit indices are 253 and 306, respectively
----- End Fatal Exception -------------------------------------------------

[slava77]

I think that the API is backward compatible. So, I wanted to test to see if synchronized merge is required.

Apparently I forgot about one runtime feature change that requires a change in cms-sw/cmssw.

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4355/16691/summary.html
COMMIT: 64d0b3c
CMSSW: CMSSW_12_0_X_2021-07-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7113/16691/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2787742
• DQMHistoTests: Total failures: 874
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2786867
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[qliphy]

tested in cms-sw/cmssw#34395

[qliphy]

+1

[qliphy]

merge