Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch master #7129

Conversation

mrodozov
Copy link
Contributor

refresh the install.sh script with new PR number

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/rootmaster.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

please test with cms-sw/cms-bot#1586

@smuzaffar
Copy link
Contributor

  1. cms-bot PR has been merged, so no need to test with it
  2. the error reported here Updated root to tip of branch master #7102 (comment) looks real. I think root might have (re)moved the RooMinuit.h here. We might need to check and fix cmssw code

@mrodozov
Copy link
Contributor Author

sure the error is real, I've built ROOT already to fix the cmssw part, the only thing we'll need the install.sh scirpt is to checkout all cmssw deps to fix all "surprises" that may pop up

@smuzaffar
Copy link
Contributor

No idea what do you mean by " install.sh scirpt is to checkout all cmssw", according to previous test the only error is in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a6883/16741/build-logs/ ( PhysicsTools/TagAndProbe )

@mrodozov
Copy link
Contributor Author

abort

@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmssw#34461

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ca634/16756/summary.html
COMMIT: f804174
CMSSW: CMSSW_12_0_X_2021-07-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7129/16756/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

FATAL: malformed spec found while quering it. Command: 
source /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/rpm-env.sh ;  rpm -q --specfile /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/tmpspec-root --info --define "cmsdist_directory /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cmsdist" --define "compilerv 930" --define "cmscompilerv 900" --define "cmsos slc7_amd64" --define "package_vectorization %{nil}" --define 'buildroot /foo'
Resulted in:

warning: Macro %rpmbuild_libdir defined but not used within scope
error: line 332: Unknown tag: <<<<<<< HEAD
error: query of specfile /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/tmpspec-root failed, can't parse
Traceback (most recent call last):
  File "./pkgtools/cmsBuild", line 4494, in 
    build(opts, args[1:], PKGFactory)
  File "./pkgtools/cmsBuild", line 3784, in build


@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#34461 for CMSSW_12_0_ROOT6_X

@mrodozov
Copy link
Contributor Author

in any case we can't have the root master change in cmssw master, unless RooMinimizer is able to substitute RooMinuit in 6.22, which means backporting this rootmaster change to 6.22

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ca634/16757/summary.html
COMMIT: f804174
CMSSW: CMSSW_12_0_ROOT6_X_2021-07-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7129/16757/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ca634/16757/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ca634/16757/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3057 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786302
  • DQMHistoTests: Total failures: 7310
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2778969
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: found differences in 1 / 37 workflows

@smuzaffar smuzaffar merged commit 5b3a940 into cms-sw:IB/CMSSW_12_0_X/rootmaster Jul 14, 2021
@mrodozov mrodozov deleted the root-update-master-20210705 branch July 14, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants