Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThePEG - remove -g flag from the compilation #7260

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Sep 1, 2021

This removes the default CXXFLAGS="-g -O2" (same for CFLAGS) to -g0 -O2 -DNDEBUG to keep the optimization, set debug info to 0 and remove assertions if any
The original lib is 123 mb, the resulting new one 6512 bytes without further check whats in it (if any debug symbols remain)
The debug info for the failing job is reduced

This removes the default CXXFLAGS="-g -O2" (same for CFLAGS) to -g0 -O2 -DNDEBUG to keep the optimization, set debug info to 0 and remove assertions if any
The original lib is 123 mb, the resulting new one 6512 bytes without further check whats in it (if any debug flags remain)
The debug info for the failing job is reduced
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2021

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Sep 1, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-806c0b/18201/summary.html
COMMIT: 9c9a6b8
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7260/18201/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-806c0b/18201/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-806c0b/18201/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000404
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3000370
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@mrodozov mrodozov deleted the remove-default-debug-option-thepeg branch September 1, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants