Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootmodule: Updated root to tip of branch master #7408

Merged
merged 1 commit into from Oct 26, 2021

Conversation

ddaina
Copy link
Contributor

@ddaina ddaina commented Oct 25, 2021

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ddaina (Daina) for branch IB/CMSSW_12_1_X/rootmodule.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@ddaina
Copy link
Contributor Author

ddaina commented Oct 25, 2021

test parameters:

  • full_cmssw = true

@ddaina
Copy link
Contributor Author

ddaina commented Oct 25, 2021

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb2ecf/19881/summary.html
COMMIT: 7f8f6c7
CMSSW: CMSSW_12_1_CXXMODULE_X_2021-10-22-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7408/19881/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb2ecf/19881/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb2ecf/19881/git-merge-result

Build

I found compilation error when building:

>> Building CXX Module LCG reflex dict from header file tmp/slc7_amd64_gcc900/src/RecoEgamma/PhotonIdentification/src/RecoEgammaPhotonIdentification/a/RecoEgammaPhotonIdentification_xr.h
In file included from input_line_8:60:
In file included from ./tmp/slc7_amd64_gcc900/src/RecoEgamma/PhotonIdentification/src/RecoEgammaPhotonIdentification/a/RecoEgammaPhotonIdentification_xr.h:37:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_CXXMODULE_X_2021-10-22-2300/src/RecoEgamma/PhotonIdentification/interface/PhotonDNNEstimator.h:4:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_CXXMODULE_X_2021-10-22-2300/src/RecoEgamma/EgammaTools/interface/EgammaDNNHelper.h:4:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_CXXMODULE_X_2021-10-22-2300/src/PhysicsTools/TensorFlow/interface/TensorFlow.h:12:10: fatal error: 'tensorflow/core/framework/tensor.h' file not found
#include "tensorflow/core/framework/tensor.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/lcg/root/6.25.01-bb305eb65af43a1dd7592a4b182e0506/bin/rootcling: compilation failure (tmp/slc7_amd64_gcc900/src/RecoEgamma/PhotonIdentification/src/RecoEgammaPhotonIdentification/a/libRecoEgammaPhotonIdentification75213a144d_dictUmbrella.h)
gmake: *** [tmp/slc7_amd64_gcc900/src/RecoEgamma/PhotonIdentification/src/RecoEgammaPhotonIdentification/a/RecoEgammaPhotonIdentification_xr.cc] Error 1
>> Compiling LCG dictionary: tmp/slc7_amd64_gcc900/src/RecoEgamma/PhotonIdentification/src/RecoEgammaPhotonIdentification/a/RecoEgammaPhotonIdentification_xr.cc


@smuzaffar
Copy link
Contributor

smuzaffar commented Oct 26, 2021

+externals
known issue with tensorflow header

@smuzaffar smuzaffar merged commit 02f0359 into cms-sw:IB/CMSSW_12_1_X/rootmodule Oct 26, 2021
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/rootmodule IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants