Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xrdcl-record package #7827

Merged
merged 6 commits into from Apr 28, 2022
Merged

Add xrdcl-record package #7827

merged 6 commits into from Apr 28, 2022

Conversation

iarspider
Copy link
Contributor

Closes #7826

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_4_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #7827 was updated.

@iarspider
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor

@iarspider , we should also add the toolfile and include it in cmssw-tool-conf otherwise bot is not going to build it.

smuzaffar
smuzaffar reviewed Apr 27, 2022
View reviewed changes
xrdcl-record.spec Outdated
@@ -0,0 +1,23 @@
### RPM external xrdcl-record 5.4.2
Source: https://github.com/xrootd/xrdcl-record/archive/refs/tags/v5.4.2.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use %{realversion} instead of hardcoded version string here

@cmsbuild
Copy link
Contributor

Pull request #7827 was updated.

@cmsbuild
Copy link
Contributor

Pull request #7827 was updated.

@iarspider
Copy link
Contributor Author

please test

smuzaffar
smuzaffar reviewed Apr 27, 2022
View reviewed changes
scram-tools.file/tools/xrdcl-record/xrdcl-record.xml Outdated
<tool name="xrdcl-record" version="@TOOL_VERSION@">
<lib name="XrdClRecorder-5"/>
<client>
<environment name="XRDCL-RECORD_BASE" default="@TOOL_ROOT@"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change this to XRDCL_RECORD_BASE i.e use of _ instead of -

@cmsbuild
Copy link
Contributor

Pull request #7827 was updated.

@cmsbuild
Copy link
Contributor

Pull request #7827 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-095e10/24262/summary.html
COMMIT: 07530bd
CMSSW: CMSSW_12_4_X_2022-04-27-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7827/24262/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1001.2 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11284 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 9776
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3685636
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

Please test for el8_ppc64le_gcc10

@smuzaffar
Copy link
Contributor

Please test for el8_aarch64_gcc10

@smuzaffar
Copy link
Contributor

Please test for el9_amd64_gcc11

@smuzaffar
Copy link
Contributor

+externals
looks good

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 4d5199b into IB/CMSSW_12_4_X/master Apr 28, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-095e10/24293/summary.html
COMMIT: 07530bd
CMSSW: CMSSW_12_4_X_2022-04-27-2300/el8_ppc64le_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7827/24293/install.sh to create a dev area with all the needed externals and cmssw changes.

@perrotta
Copy link
Contributor

+externals looks good

Great! Thank you @smuzaffar and @iarspider
Is any backport needed to have this also available for 12_3? IOW, since all other ingredients needed to build 12_3_2 have been already merged, what's missing to have also this in 12_3?

@smuzaffar
Copy link
Contributor

sure, I will open a PR for 12.3.X now

@cmsbuild cmsbuild mentioned this pull request Apr 28, 2022
Merged
@cmsbuild
Copy link
Contributor

backport done
Successfully backported PR #7827 as #7830 for branch IB/CMSSW_12_3_X/master

@smuzaffar
Copy link
Contributor

@perrotta , #7830 is now available

@iarspider iarspider deleted the add-xrdcl_record branch April 28, 2022 06:41
@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-095e10/24291/summary.html
COMMIT: 07530bd
CMSSW: CMSSW_12_4_X_2022-04-27-2300/el8_aarch64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7827/24291/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestFWCoreServicesDriver had ERRORS

RelVals

  • 11634.711634.7_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/step2_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano.log

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-095e10/24292/summary.html
COMMIT: 07530bd
CMSSW: CMSSW_12_4_X_2022-04-27-2300/el9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7827/24292/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 70416 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 427638
  • DQMHistoTests: Total nulls: 347
  • DQMHistoTests: Total successes: 3267427
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.6480000000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.975 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 0.996 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.054 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -0.269 KiB SiStrip/MechanicalView
  • Checked 205 log files, 45 edm output root files, 49 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add xrootd recorder plugin
4 participants
@iarspider @cmsbuild @smuzaffar @perrotta