Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.3.X] Add xrdcl-record package #7830

Merged

Conversation

cmsbuild
Copy link
Contributor

backport of #7827

Closes #7826

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Apr 28, 2022

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_12_3_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar smuzaffar changed the title Add xrdcl-record package [12.3.X] Add xrdcl-record package Apr 28, 2022
@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

@qliphy , @perrotta currently in 12.3.X we have xrootd version 5.4.1. Should we also backport 5.4.2 from 12.4.X ?

@qliphy
Copy link
Contributor

qliphy commented Apr 28, 2022

@qliphy , @perrotta currently in 12.3.X we have xrootd version 5.4.1. Should we also backport 5.4.2 from 12.4.X ?

@smuzaffar Upon other requests, we plan to cut next 12_3 release quite soon (probably today). So probably it is fine to stay with 5.4.1 unless @dmytro has any concern here.

@perrotta
Copy link
Contributor

@qliphy , @perrotta currently in 12.3.X we have xrootd version 5.4.1. Should we also backport 5.4.2 from 12.4.X ?

@smuzaffar Upon other requests, we plan to cut next 12_3 release quite soon (probably today). So probably it is fine to stay with 5.4.1 unless @dmytro has any concern here.

@smuzaffar @qliphy this PR is indeed the main reason to have 12_3 cut as soon as possible, Therefore, if there is anything missing that can be useful at T0, better to have it merged sooner than later. Therefore, I'd stick on whatever @dmytro and the T0 crew consider the more appropriate. (And yes, if there are no preferences about it, I'd go for the fastest option).

@smuzaffar
Copy link
Contributor

+externals
next external xrd-record built fine. There is nothing in cmssw which uses it so it is safe to merge

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 14625cb into IB/CMSSW_12_3_X/master Apr 28, 2022
@smuzaffar
Copy link
Contributor

@qliphy @perrotta , 12.3.X branches are now ready to build the release

@perrotta
Copy link
Contributor

@qliphy @perrotta , 12.3.X branches are now ready to build the release

Thank you!

@cmsbuild
Copy link
Contributor Author

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea7fd5/24295/summary.html
COMMIT: 51a6d68
CMSSW: CMSSW_12_3_X_2022-04-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7830/24295/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697135
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3697099
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar deleted the backport-IB_CMSSW_12_3_X_master-7827 branch May 2, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants