New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hwloc to version 2.8.0 #7979
Update hwloc to version 2.8.0 #7979
Conversation
API changes: - Add HWLOC_TOPOLOGY_FLAG_NO_DISTANCES, _NO_MEMATTRS and _NO_CPUKINDS to reduce the overhead when unneeded. - Add separate Read/Write Bandwidth/Latency memory attributes and implement them on Linux. Backends changes: - NUMA nodes may now have a subtype such as DRAM, HBM, SPM, or NVM on heterogeneous memory platforms on Linux. - Add DAXType and DAXParent attributes on Linux to tell where a DAX device or its corresponding NUMA node come from (SPM for Specific-Purpose or NVM for Non-Volatile Memory). - Detect heterogeneous caches in hybrid CPUs on MacOS X, thanks to Paul Bone for the help. - Max frequencies are not ignored in Linux cpukinds anymore (they were ignored in hwloc 2.7.0), but they may be slightly adjusted to avoid reporting hybrid CPUs because Intel Turbo Boost Max 3.0. - See the documentation of environment variable HWLOC_CPUKINDS_MAXFREQ. - Hardwire the PCI locality of HPE Cray EX235a nodes. Tools - lstopo and other tools may now load Linux and x86 cpuid topology files from a tarball. - lstopo may now replace the P# and L# index prefixes with custom strings thanks to --os-index-prefix and --logical-index-prefix options. Misc - Add --disable-readme to avoid regenerating the top-level hwloc README file from the documentation.
please test |
A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_12_5_X/master. @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
please test for el8_amd64_gcc11 |
please test for el8_aarch64_gcc10 |
please test for slc7_amd64_gcc10 |
please test for el8_ppc64le_gcc10 |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a21c20/26023/summary.html External BuildI found compilation error when building: + OSDIR=/cvmfs/patatrack.cern.ch/externals/aarch64/rhel8 + '[' -d /cvmfs/patatrack.cern.ch/externals/aarch64/rhel8 ']' + BASEDIR=/cvmfs/patatrack.cern.ch/externals/aarch64/rhel8/amd/rocm-5.0.2 + mkdir /data/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/95c215630c939706b0552e3eee38861c/opt/cmssw/el8_aarch64_gcc10/external/rocm/5.0.2-95c215630c939706b0552e3eee38861c/bin + test -d /cvmfs/patatrack.cern.ch/externals/aarch64/rhel8/amd/rocm-5.0.2/bin error: Bad exit status from /data/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Xd95Tq (%install) RPM build errors: line 35: It's not recommended to have unversioned Obsoletes: Obsoletes: external+rocm+5.0.2-95c215630c939706b0552e3eee38861c Bad exit status from /data/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Xd95Tq (%install) |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a21c20/26024/summary.html External BuildI found compilation error when building: + OSDIR=/cvmfs/patatrack.cern.ch/externals/ppc64le/rhel8 + '[' -d /cvmfs/patatrack.cern.ch/externals/ppc64le/rhel8 ']' + BASEDIR=/cvmfs/patatrack.cern.ch/externals/ppc64le/rhel8/amd/rocm-5.0.2 + mkdir /scratch/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/95c215630c939706b0552e3eee38861c/opt/cmssw/el8_ppc64le_gcc10/external/rocm/5.0.2-95c215630c939706b0552e3eee38861c/bin + test -d /cvmfs/patatrack.cern.ch/externals/ppc64le/rhel8/amd/rocm-5.0.2/bin error: Bad exit status from /scratch/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.wymOqy (%install) RPM build errors: line 35: It's not recommended to have unversioned Obsoletes: Obsoletes: external+rocm+5.0.2-95c215630c939706b0552e3eee38861c Bad exit status from /scratch/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.wymOqy (%install) |
hwloc.spec
Outdated
|
||
BuildRequires: autotools | ||
Requires: cuda libpciaccess libxml2 numactl | ||
Requires: cuda libpciaccess libxml2 numactl rocm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fwyzard , rocm
is only available for x86_64
. So I guess this should be a conditional dependency i.e.
%ifarch x86_64
Requires: rocm
%endif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and also the dependency on cuda should be confitional. I'll slowly make those changes.
--enable-libxml2 \ | ||
--disable-cairo \ | ||
--disable-doxygen \ | ||
--enable-plugins=cuda,nvml \ | ||
--with-cuda=$CUDA_ROOT \ | ||
--with-rocm=$ROCM_ROOT \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here (only for x86_64)
Enable ROCm support, and rework CUDA support
1440ae1
to
e5ef1c5
Compare
please test for el8_ppc64le_gcc10 |
Pull request #7979 was updated. |
please test for el8_aarch64_gcc10 |
please test |
please test for el8_amd64_gcc11 |
please test for slc7_amd64_gcc10 |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Unit TestsI found errors in the following unit tests: ---> test DRNTest had ERRORS ---> test TestFWCoreServicesDriver had ERRORS ---> test testFWCoreUtilities had ERRORS |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Unit TestsI found errors in the following unit tests: ---> test testONNXRuntime had ERRORS ---> test DRNTest had ERRORS ---> test testFWCoreUtilities had ERRORS |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a21c20/26042/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
+1 Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a21c20/26044/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_5_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
No, let's merge it. |
API changes:
to reduce the overhead when unneeded.
implement them on Linux.
Backends changes:
on heterogeneous memory platforms on Linux.
DAX device or its corresponding NUMA node come from (SPM for
Specific-Purpose or NVM for Non-Volatile Memory).
thanks to Paul Bone for the help.
ignored in hwloc 2.7.0), but they may be slightly adjusted to avoid
reporting hybrid CPUs because Intel Turbo Boost Max 3.0.
Tools:
from a tarball.
thanks to --os-index-prefix and --logical-index-prefix options.
Misc:
file from the documentation.
Other change: