Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zstd to latest version 1.5.2 #8221

Merged
merged 1 commit into from Dec 15, 2022

Conversation

aandvalenzuela
Copy link
Contributor

Resolves #8220

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2022

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_13_0_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2022

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f3d84/29519/summary.html
COMMIT: ed245bb
CMSSW: CMSSW_13_0_X_2022-12-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29519/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestRecoEgammaElectronIdentification had ERRORS
---> test testTauEmbeddingProducers had ERRORS

RelVals

----- Begin Fatal Exception 09-Dec-2022 01:52:45 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22NoIsoV1/EB1_5.weights.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29519/CMSSW_13_0_X_2022-12-08-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29519/CMSSW_13_0_X_2022-12-08-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29519/CMSSW_13_0_X_2022-12-08-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2022-12-08-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2022-12-08-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.7611_RunJetHT2016EreMINIAOD
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 09-Dec-2022 01:52:46 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22NoIsoV1/EB1_5.weights.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29519/CMSSW_13_0_X_2022-12-08-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29519/CMSSW_13_0_X_2022-12-08-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29519/CMSSW_13_0_X_2022-12-08-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2022-12-08-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2022-12-08-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8311_RunJetHT2017FreMINIAOD
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 09-Dec-2022 01:52:48 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22NoIsoV1/EB1_5.weights.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29519/CMSSW_13_0_X_2022-12-08-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29519/CMSSW_13_0_X_2022-12-08-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29519/CMSSW_13_0_X_2022-12-08-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2022-12-08-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2022-12-08-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.88811_RunJetHT2018DreMINIAODUL
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

@smuzaffar
Copy link
Contributor

please test
a data external was not merged in cmsdist which was causing these missing data file errors

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f3d84/29527/summary.html
COMMIT: ed245bb
CMSSW: CMSSW_13_0_X_2022-12-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29527/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f3d84/29527/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f3d84/29527/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 917 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3420548
  • DQMHistoTests: Total failures: 1207
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3419319
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 103.15299999999995 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1001.0 ): 1.181 KiB AlCaReco/SiStripHitEfficiency
  • DQMHistoSizes: changed ( 10024.0,... ): 3.719 KiB EgammaV/ElectronMcFakeValidator
  • DQMHistoSizes: changed ( 11634.0,... ): 1.658 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 1.088 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 20834.0,... ): 1.062 KiB EgammaV/ElectronMcFakeValidator
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test
rerun tests based on newer IB

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f3d84/29540/summary.html
COMMIT: ed245bb
CMSSW: CMSSW_13_0_X_2022-12-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8221/29540/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestGeneratorInterfacePythia8InterfaceCompareExternalStreams had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1251 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421510
  • DQMHistoTests: Total failures: 3903
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3417585
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aandvalenzuela
Copy link
Contributor Author

please test

  • Test TestGeneratorInterfacePythia8InterfaceCompareExternalStreams failed due to time out

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f3d84/29560/summary.html
COMMIT: ed245bb
CMSSW: CMSSW_13_0_X_2022-12-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8221/29560/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestConfigDP had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421510
  • DQMHistoTests: Total failures: 152
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421336
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aandvalenzuela
Copy link
Contributor Author

Unit Test TestConfigDP failure is a global issue (cms-sw/cmssw#40301) and unrelated to this PR.

@smuzaffar
Copy link
Contributor

please test
lets rerun based on newer IB

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f3d84/29608/summary.html
COMMIT: ed245bb
CMSSW: CMSSW_13_0_X_2022-12-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8221/29608/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 59 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421510
  • DQMHistoTests: Total failures: 1226
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3420262
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 76941.71699999998 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 640.710 KiB JetMET/PFCandidates
  • DQMHistoSizes: changed ( 23234.0,... ): 448.898 KiB ParticleFlow/slimmedJetValidation
  • DQMHistoSizes: changed ( 23234.0,... ): 263.359 KiB ParticleFlow/slimmedElectronValidation
  • DQMHistoSizes: changed ( 23234.0,... ): 261.354 KiB ParticleFlow/slimmedMuonValidation
  • DQMHistoSizes: changed ( 23234.0,... ): 239.348 KiB ParticleFlow/slimmedMETValidation
  • DQMHistoSizes: changed ( 23234.0,... ): 239.010 KiB Physics/Top
  • DQMHistoSizes: changed ( 23234.0,... ): 224.329 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 23234.0,... ): 37.338 KiB ParticleFlow/PFJetResValidation
  • DQMHistoSizes: changed ( 23234.0,... ): 24.309 KiB Tracking/PackedCandidate
  • DQMHistoSizes: changed ( 23234.0,... ): 0.413 KiB JetMET/vertices
  • DQMHistoSizes: changed ( 23234.0 ): ...
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test
no idea why this shows DQM comparison differences

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f3d84/29620/summary.html
COMMIT: ed245bb
CMSSW: CMSSW_13_0_X_2022-12-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8221/29620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 27 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557521
  • DQMHistoTests: Total failures: 1188
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3556311
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update zstd to latest version 1.5.2
3 participants