Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LTO for IBs using master branch #8332

Merged

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@aandvalenzuela
Copy link
Contributor Author

And here the new branch for non-LTO IBs: https://github.com/cms-sw/cmsdist/tree/IB/CMSSW_13_1_X/nonlto

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 23, 2023

test parameters:

  • full_cmssw = true
  • skip_tests = static,header

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#40857

@smuzaffar
Copy link
Contributor

+externals
@perrotta @rappoccio this change will enable LTO for 13.1.X IBs. We will also disable special LTO IBs but build a NONLTO_X IBs (just in case)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 8b84b18 into cms-sw:IB/CMSSW_13_1_X/master Feb 23, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ff72d/30829/summary.html
COMMIT: 9d74d5d
CMSSW: CMSSW_13_1_X_2023-02-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8332/30829/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ff72d/30829/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ff72d/30829/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.596 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 293 lines from the logs
  • Reco comparison results: 61441 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3528709
  • DQMHistoTests: Total failures: 144226
  • DQMHistoTests: Total nulls: 204
  • DQMHistoTests: Total successes: 3384257
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.4149999999999999 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.715 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): -1.439 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.885 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.254 KiB SiStrip/MechanicalView
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 17 / 47 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants