Drop unused lto flags in BigProducts/Simulation BuildFile

[aandvalenzuela]

Hello,

We are enabling LTO for IBs (See cms-sw/cmsdist#8332 and cms-sw/cms-bot#1943) and we have realized there is this build file dropping some flags in case release name does not contain _LTO_. Those flags are not used anymore, so we would need to drop this condition.

Thanks,
Andrea.

FYI, @smuzaffar

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40857/34317

• This PR adds an extra 8KB to repository

[cmsbuild]

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for master.

It involves the following packages:

• BigProducts/Simulation (core, simulation)

@makortel, @smuzaffar, @civanch, @Dr15Jones, @mdhildreth can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

I confirm that unused -flto flag was dropped from the configuration many months ago ( cms-sw/cmssw-config@8d8e331 ) so there is no need to contain this condition. This cleanup will allow us to enable LTO flags for master branch

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5392d8/30828/summary.html
COMMIT: 0c2a9e0
CMSSW: CMSSW_13_1_X_2023-02-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40857/30828/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @fwyzard Remove the CUDAService from the HLT configuration #40852
• @Dr15Jones Add space for null termination in CSCChamberTimeCorrectionsValues #40853

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5392d8/30828/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5392d8/30828/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.596 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 12 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3528709
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3528684
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[smuzaffar]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[cmsbuild]

backport done
Successfully backported PR #40857 as #40892 for branch CMSSW_13_0_X