Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fasthadd file permissions #978

Merged
3 commits merged into from Oct 1, 2014
Merged

fasthadd file permissions #978

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e23d861
New version of fastHadd with correct file permissions.
Sep 1, 2014
8499c30
Style change: use a global variable named commit instead of tag, as w…
Sep 1, 2014
c2d54cd
Fix comments.
Sep 1, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions fasthadd.spec
View file
Open in desktop
@@ -1,8 +1,8 @@
### RPM external fasthadd 1.0
### RPM external fasthadd 1.1

%define tag 743bde9939bbc4f34c2b4fd022cfb980314f912a
Source0: https://raw.githubusercontent.com/cms-sw/cmssw/%tag/DQMServices/Components/bin/fastHadd.cc
Source1: https://raw.githubusercontent.com/cms-sw/cmssw/%tag/DQMServices/Core/src/ROOTFilePB.proto
%define commit e193ee35083c2c1583e186130891087d6a4c7ac1 #commit mapped to CMSSW_7_1_6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you actually try this out? # is not a commend character for rpm keywords (like %define). You might want to move the comment above the define.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktf
I checked it with rpmlint, it was ok: mmhh :-(
Fixing it right now.
BTW, can you point me to the cmsbuild documentation? I found only sparse stuff in the Twiki.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all we have is in:

https://github.com/cms-sw/pkgtools/tree/V00-22-XX/docs

and it's admittedly sparse. Will try to improve it as I find time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no!
So dummy, I have bookmarked it... Shame on me :-(

Source0: https://raw.githubusercontent.com/cms-sw/cmssw/%commit/DQMServices/Components/bin/fastHadd.cc
Source1: https://raw.githubusercontent.com/cms-sw/cmssw/%commit/DQMServices/Core/src/ROOTFilePB.proto
Requires: protobuf root

%prep
Expand Down