Further CaloL2 O2O updates #24922
Further CaloL2 O2O updates #24922
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24922/6895 |
|
A new Pull Request was created by @bundocka for master. It involves the following packages: L1Trigger/L1TCalorimeter @nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please @bundocka , indicates in the title which subsystem you are talking about : many other detectors (ecal, tracker etc..) are also using 020 in cmssw, it's hard to keep track if the title is not explicit enough , thank you |
|
CaloL2. Apologies for not being clear. I meant to add in the comments, this is not critical for the tests at the end of the week, so does not need to be added to |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24922/6896 |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 2905870 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-17-2300/src/L1TriggerConfig/Utilities/src/L1TCaloParamsViewer.cc
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-17-2300/src/L1TriggerConfig/Utilities/src/L1TriggerKeyExtViewer.cc
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-17-2300/src/L1TriggerConfig/Utilities/src/L1TMuonGlobalParamsViewer.cc
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-17-2300/src/L1TriggerConfig/Utilities/src/L1TMuonOverlapParamsWriter.cc
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-17-2300/src/L1TriggerConfig/Utilities/src/L1TCaloParamsViewer.cc: In member function 'virtual void L1TCaloParamsViewer::analyze(const edm::Event&, const edm::EventSetup&)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-17-2300/src/L1TriggerConfig/Utilities/src/L1TCaloParamsViewer.cc:463:49: error: 'class l1t::CaloParamsHelper' has no member named 'etSumXCalibrationType'; did you mean 'etSumEttCalibrationType'?
cout<<" etSumXCalibrationType= " << ptr1->etSumXCalibrationType() << endl;
^~~~~~~~~~~~~~~~~~~~~
etSumEttCalibrationType
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-17-2300/src/L1TriggerConfig/Utilities/src/L1TCaloParamsViewer.cc:464:49: error: 'class l1t::CaloParamsHelper' has no member named 'etSumYCalibrationType'; did you mean 'etSumEttCalibrationType'?
cout<<" etSumYCalibrationType= " << ptr1->etSumYCalibrationType() << endl;
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
Superseded by #24931 |
Further CaloL2 O2O updates (supersedes #24922)
This PR brings the caloL2 O2O fully inline with the firmware.
NB. The etSumXCalibration & etSumYCalibration nodes that have been repurposed in CaloParamsHelper.h and CaloParamsHelperO2O.h were never used anywhere in CMSSW, so this is backwards compatible.