[HBHE] Mahi configuration change: 8 pulses without baseline #25469

jaehyeok · 2018-12-11T10:59:23Z

HCAL DPG wants to make changes to the configuration of Mahi; we like to use 8 pulses instead of 3 and remove the baseline.

It was noticed that Mahi fit sometimes does not fit data correctly, particularly when there is a significant charge in OOT time slices. Also, the baseline is occasionally incapable of extracting a flat component properly.

We tested various configurations (different number of pulses and with/without baseline), and found that the 8-pulse without baseline fit performs best.

Details can be found in [1]. There are links to more studies (p35).

[1] https://indico.cern.ch/event/774376/contributions/3230469/attachments/1764961/2865685/20181204_Jae_HCALDPG_RecoConfigUL.pdf

…gative.

cmsbuild · 2018-12-11T10:59:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-12-11T11:03:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25469/7570

cmsbuild · 2018-12-11T11:03:34Z

A new Pull Request was created by @jaehyeok for master.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mariadalfonso, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2018-12-11T11:07:57Z

please test

cmsbuild · 2018-12-11T11:08:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32118/console Started: 2018/12/11 12:08

slava77 · 2018-12-11T12:47:08Z

@jaehyeok
please provide some timing measurements.
Data and ttbar MC PU50 is probably enough.

slava77 · 2018-12-11T12:48:14Z

@jaehyeok
please provide some timing measurements.
Data and ttbar MC PU50 is probably enough.

(I meant CPU timing)
igprof would be the best
https://twiki.cern.ch/twiki/bin/viewauth/CMS/RecoIntegration#Run_profiler_igprof

cmsbuild · 2018-12-11T13:20:04Z

+1
Tested at: cf807a3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25469/32118/summary.html

cmsbuild · 2018-12-11T13:20:08Z

Comparison job queued.

cmsbuild · 2018-12-11T15:37:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25469/32118/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 18161 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3136422
DQMHistoTests: Total failures: 3902
DQMHistoTests: Total nulls: 25
DQMHistoTests: Total successes: 3132291
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.04 KiB( 32 files compared)
DQMHistoSizes: changed ( 136.731,... ): -0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 4.53 ): 0.023 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.85 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.788 ): -0.031 KiB JetMET/SUSYDQM
Checked 137 log files, 14 edm output root files, 33 DQM output files

jaehyeok · 2018-12-11T16:40:29Z

@slava77

@jaehyeok
please provide some timing measurements.
Data and ttbar MC PU50 is probably enough.

(I meant CPU timing)
igprof would be the best
https://twiki.cern.ch/twiki/bin/viewauth/CMS/RecoIntegration#Run_profiler_igprof

I ran over 500 JetHT events in Run2018A [1]. These events correspond to nPU~50 because they are at the beginning of a fill (Fill 6729).

The following are the igprof results using (1) 3 pulses + baseline and (2) 8 pulses. The full igprof results are in [2].

(1) 3 pulses + baseline

Rank    % total       Self       Self / Children   Function
[17]       35.6      38.79       0.55 / 38.24      MahiFit::phase1Apply(HBHEChannelInfo const&, float&, float&, bool&, float&) const
           34.6  .........      37.77 / 37.77        MahiFit::doFit(std::array<float, 3ul>&, int) const [18]
            0.4  .........       0.47 / 0.47         MahiFit::resetWorkspace() const [504]
            0.0  .........       0.01 / 0.86         _init [339]

(2) 8 pulses

Rank    % total       Self       Self / Children   Function
[12]       54.1      73.31       0.70 / 72.61      MahiFit::phase1Apply(HBHEChannelInfo const&, float&, float&, bool&, float&) const
           53.2  .........      72.18 / 72.18        MahiFit::doFit(std::array<float, 3ul>&, int) const [13]
            0.3  .........       0.41 / 0.41         MahiFit::resetWorkspace() const [528]
            0.0  .........       0.01 / 1.14         _init [281]

The processing time increased by about a factor of 2.

[1] /store/data/Run2018A/JetHT/RAW/v1/000/316/944/00000/2EF71399-6B64-E811-9B71- FA163ED59971.root
[2] http://jaehyeok.web.cern.ch/jaehyeok/HCAL/igprof/

abdoulline · 2018-12-12T08:26:55Z

Here is an additional sanity check, comparing 2018 single-pion scan w/wo this PR

https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/calo_scan_single_pi/10_X/10_4_X_8pulses_vs_10_4_X_std_SinglePi/

cmsbuild · 2018-12-19T23:41:31Z

Pull request #25469 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2018-12-19T23:43:57Z

@cmsbuild please test

cmsbuild · 2018-12-19T23:45:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32282/console Started: 2018/12/20 00:46

slava77 · 2018-12-20T00:16:10Z

Some more plots:

these are from flat-pt dijet with PU50 MC (wf 11071)

the new is on the right. I guess this is better (I can't think of a clear reason we should have a two-branch relationship between M0 (raw) and MAHI (I guess M2 here is a misnomer in the plots).

The times are just reiterated to be "random"

jaehyeok · 2018-12-20T00:41:53Z

In the top plots, I guess x-axis is M0 and y-axis is Mahi?

slava77 · 2018-12-20T01:08:44Z

On 12/19/18 4:41 PM, jaehyeok wrote: In the top plots, I guess x-axis is M0 and y-axis is Mahi?

I think so; but I didn't make an explicit check in the code. Since this is coming from DQM, I'm assuming the plots are widely known.

cmsbuild · 2018-12-20T01:48:14Z

+1
Tested at: 10874a1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25469/32282/summary.html

cmsbuild · 2018-12-20T01:48:17Z

Comparison job queued.

cmsbuild · 2018-12-20T03:33:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25469/32282/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 21138 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3153717
DQMHistoTests: Total failures: 5385
DQMHistoTests: Total nulls: 27
DQMHistoTests: Total successes: 3148101
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.007 KiB( 32 files compared)
DQMHistoSizes: changed ( 136.731 ): -0.035 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 4.53 ): -0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 1000.0 ): 0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.788 ): 0.020 KiB JetMET/SUSYDQM
Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77 · 2018-12-20T04:25:42Z

+1

for #25469 10874a1

code changes are in line with the PR description and the follow up review
jenkins tests pass and comparisons with the baseline show expected differences starting from hbhe(pre)reco
- changes in the energy measurements do not have an immediate follow up (except maybe revisiting the chi2 switch point)
- changes in the hit time distribution imply more work to be followed up in revisit HBHE MAHI algorithm hit time #25526
results of local tests with more stats were posted earlier in the thread

cmsbuild · 2018-12-20T04:26:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

abdoulline · 2018-12-20T06:23:20Z

In the top plots, I guess x-axis is M0 and y-axis is Mahi?

"Better late than never" (to answer): yes, X: M0, Y: default energy (MAHI).
The histo name just wasn't properly renamed when the default moved from M2 to MAHI...

fabiocos · 2018-12-20T07:23:20Z

+1

jaehyeok added 2 commits December 11, 2018 00:26

mahi uses 8 pulses without baseline. avoid charge - pedestal being ne…

85ff957

…gative.

remove non-negativity requirement

cf807a3

cmsbuild added this to the CMSSW_10_4_X milestone Dec 11, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Dec 11, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 11, 2018

cmsbuild added tests-started and removed tests-pending labels Dec 11, 2018

cmsbuild added tests-approved and removed tests-started labels Dec 11, 2018

cmsbuild added comparison-available and removed comparison-pending labels Dec 11, 2018

Added a flag use8ts so that 8-pulse fit can be selected in a config file

c810379

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 19, 2018

cmsbuild added tests-started and removed tests-pending labels Dec 19, 2018

cmsbuild added tests-approved and removed tests-started labels Dec 20, 2018

slava77 mentioned this pull request Dec 20, 2018

revisit HBHE MAHI algorithm hit time #25526

Closed

cmsbuild added comparison-available and removed comparison-pending labels Dec 20, 2018

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Dec 20, 2018

cmsbuild added orp-approved and removed orp-pending labels Dec 20, 2018

cmsbuild merged commit 9529af0 into cms-sw:master Dec 20, 2018

vkhristenko mentioned this pull request Feb 5, 2019

HCAL Reco with CUDA cms-patatrack/cmssw#268

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HBHE] Mahi configuration change: 8 pulses without baseline #25469

[HBHE] Mahi configuration change: 8 pulses without baseline #25469

jaehyeok commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

perrotta commented Dec 11, 2018

cmsbuild commented Dec 11, 2018 •

edited

slava77 commented Dec 11, 2018

slava77 commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

jaehyeok commented Dec 11, 2018

abdoulline commented Dec 12, 2018 •

edited

cmsbuild commented Dec 19, 2018

slava77 commented Dec 19, 2018

cmsbuild commented Dec 19, 2018 •

edited

slava77 commented Dec 20, 2018

jaehyeok commented Dec 20, 2018

slava77 commented Dec 20, 2018 via email

cmsbuild commented Dec 20, 2018

cmsbuild commented Dec 20, 2018

cmsbuild commented Dec 20, 2018

slava77 commented Dec 20, 2018

cmsbuild commented Dec 20, 2018

abdoulline commented Dec 20, 2018

fabiocos commented Dec 20, 2018

[HBHE] Mahi configuration change: 8 pulses without baseline #25469

[HBHE] Mahi configuration change: 8 pulses without baseline #25469

Conversation

jaehyeok commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

perrotta commented Dec 11, 2018

cmsbuild commented Dec 11, 2018 • edited

slava77 commented Dec 11, 2018

slava77 commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

cmsbuild commented Dec 11, 2018

jaehyeok commented Dec 11, 2018

abdoulline commented Dec 12, 2018 • edited

cmsbuild commented Dec 19, 2018

slava77 commented Dec 19, 2018

cmsbuild commented Dec 19, 2018 • edited

slava77 commented Dec 20, 2018

jaehyeok commented Dec 20, 2018

slava77 commented Dec 20, 2018 via email

cmsbuild commented Dec 20, 2018

cmsbuild commented Dec 20, 2018

cmsbuild commented Dec 20, 2018

slava77 commented Dec 20, 2018

cmsbuild commented Dec 20, 2018

abdoulline commented Dec 20, 2018

fabiocos commented Dec 20, 2018

cmsbuild commented Dec 11, 2018 •

edited

abdoulline commented Dec 12, 2018 •

edited

cmsbuild commented Dec 19, 2018 •

edited