Prevent too many chunks from being added per function call.

[bbockelm]

We have a limit of 1,024 chunks per IO vector and stop adding new
chunks once we hit 1,000. However, the consumeChunk* calls previously
were able to add an unlimited number of new chunks - meaning that we
could go past the limit in a single loop iteration.

[cmsbuild]

A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_7_4_X.

Prevent too many chunks from being added per function call.

It involves the following packages:

Utilities/XrdAdaptor

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

please test

[Dr15Jones]

Please also make versions for 7_5 and 7_6.

[cmsbuild]

The tests are being triggered in jenkins.

[bbockelm]

@cmsbuild @Dr15Jones - what happened to the jenkins tests?

I was planning on cherry picking to 7_5 / 7_6 once the tests passed.

[Dr15Jones]

@smuzaffar Were the tests stuck?

[bbockelm]

@smuzaffar any updates on the jenkins tests for this one?

[smuzaffar]

please test
I can not find any histosy of this OPRin jenkins tests, so triggering it again

[bbockelm]

@smuzaffar - are we just unlucky for this PR?

[davidlange6]

@cmsbuild please test

should be better now

On Jul 9, 2015, at 4:39 AM, Brian Bockelman notifications@github.com wrote:

@smuzaffar - are we just unlucky for this PR?

—
Reply to this email directly or view it on GitHub.

[smuzaffar]

I thought that adding "please test" will trigger the tests but looks
like it does not. I guess one needs to remove the "test started" label too.
Anyway, I have force the tests in jenkins now

On 07/09/2015 07:36 AM, David Lange wrote:

@cmsbuild please test

should be better now

On Jul 9, 2015, at 4:39 AM, Brian Bockelman
notifications@github.com wrote:

@smuzaffar - are we just unlucky for this PR?

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#10021 (comment).

[smuzaffar]

@davidlange6 , do we want to add in 74X without testit in 75X/76X?

[cmsbuild]

+1
Tested at: 53e2f4d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10021/6085/summary.html

[Dr15Jones]

+1

[Dr15Jones]

@davidlange6 How do you want to proceed with actual large scale test of this? Shahzad asked if this really should be in 7_5 or 7_6 first. Or did I miss a related pull request?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[bbockelm]

@davidlange6 - What's the strategy on this one?

[davidlange6]

@bbockelm -good point - is not there not a 75x or 76x version of this?

[davidlange6]

+1