Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port 75X #10072

Merged
merged 2 commits into from Jul 15, 2015
Merged

Forward port 75X #10072

merged 2 commits into from Jul 15, 2015

Conversation

emiglior
Copy link
Contributor

@emiglior emiglior commented Jul 7, 2015

Clean-up of the MuScleFit code (studies on the muon momentum scale) for run2.
This is the forward port to CMSSW_7_5_X of the PR #8700 which entered in CMSSW_7_2_5.
RECO is not affected.
@maralxplus, @mabarrio This can be of interest for you as well

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

A new Pull Request was created by @emiglior (Ernesto Migliore) for CMSSW_7_5_X.

Forward port 75X

It involves the following packages:

MuonAnalysis/MomentumScaleCalibration

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@bellan, @mmusich, @frmeier, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@emiglior
Copy link
Contributor Author

emiglior commented Jul 9, 2015

@vadler @Degano @monttj could you start the tests?

@monttj
Copy link
Contributor

monttj commented Jul 10, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Jul 10, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants