Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-hcs23 Modify to add the adequate ESProducers in the configuration scenarios #10267

Merged
merged 3 commits into from Jul 23, 2015
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryDesign_cff.py
Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsDesignGeometryXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometry2015MuonGEMDevXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometry2015ZeroMaterialXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometry2015XML_RPC2Gap_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometry2015XML_RPC4RE11_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtended2015_cff.py
Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometry2015XML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

Expand Up @@ -30,4 +30,5 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda - which PR pre seeds this one? I do not see this configuration fragment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, it's in bsunanda/Run2-hcx22, but the definition in it is wrong for DB: hcalParameters_cfi should not be included in this case.


2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtended2016_cff.py
Expand Up @@ -6,3 +6,5 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometry2016XML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
Expand Up @@ -29,4 +29,5 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *

2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtended2017_cff.py
Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometry2017XML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

Expand Up @@ -31,4 +31,5 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *

2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtended2019_cff.py
Expand Up @@ -6,3 +6,5 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometry2019XML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
Expand Up @@ -45,4 +45,4 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalRecNumberingInitialization_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *
Expand Up @@ -45,4 +45,4 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalRecNumberingInitialization_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *
Expand Up @@ -49,5 +49,5 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalRecNumberingInitialization_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *

Expand Up @@ -49,5 +49,5 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalRecNumberingInitialization_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *

Expand Up @@ -30,3 +30,4 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *
Expand Up @@ -5,4 +5,5 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometry2023MuonXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerTopology_cfi import *
#from Geometry.HcalCommonData.hcalSimNumberingInitialization_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
Expand Up @@ -29,4 +29,4 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *

from Geometry.HcalCommonData.hcalDDConstants_cff import *
Expand Up @@ -51,4 +51,4 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalRecNumberingInitialization_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *
Expand Up @@ -51,4 +51,4 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalRecNumberingInitialization_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *
Expand Up @@ -51,4 +51,4 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalRecNumberingInitialization_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *
Expand Up @@ -51,4 +51,4 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalRecNumberingInitialization_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *
2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtended2023_cff.py
Expand Up @@ -6,3 +6,5 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometry2023XML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtendedGFlash_cff.py
Expand Up @@ -6,6 +6,8 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometryGFlashXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

# Reconstruction geometry services
from Configuration.Geometry.GeometryReco_cff import *
Expand Up @@ -6,3 +6,5 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometryHFLibraryNoCastorXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtendedLiMax_cff.py
Expand Up @@ -6,6 +6,8 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometryLiMaxXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

# Reconstruction geometry services
from Configuration.Geometry.GeometryReco_cff import *
2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtendedLiMin_cff.py
Expand Up @@ -6,6 +6,8 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometryLiMinXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

# Reconstruction geometry services
from Configuration.Geometry.GeometryReco_cff import *
Expand Up @@ -30,4 +30,4 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalRecNumberingInitialization_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *
Expand Up @@ -6,4 +6,5 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometryPhase2TkBE5DPixel10DXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumbering2023Geometry_cfi import *
from Geometry.HcalCommonData.hcalSimNumberingInitialization_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
Expand Up @@ -29,4 +29,5 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *

Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometryPhaseIPixelXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtendedTest2014_cff.py
Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometryTest2014XML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtendedX0Max_cff.py
Expand Up @@ -6,6 +6,8 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometryX0MaxXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

# Reconstruction geometry services
from Configuration.Geometry.GeometryReco_cff import *
2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtendedX0Min_cff.py
Expand Up @@ -6,6 +6,8 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometryX0MinXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

# Reconstruction geometry services
from Configuration.Geometry.GeometryReco_cff import *
Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometryZeroMaterialXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryExtended_cff.py
Expand Up @@ -9,4 +9,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsExtendedGeometryXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryIdeal2015_cff.py
Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsIdealGeometry2015XML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryIdeal2015dev_cff.py
Expand Up @@ -6,4 +6,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsIdealGeometry2015devXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

1 change: 1 addition & 0 deletions Configuration/Geometry/python/GeometryIdealAPD1_cff.py
Expand Up @@ -28,4 +28,5 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *

1 change: 1 addition & 0 deletions Configuration/Geometry/python/GeometryIdealNoAPD_cff.py
Expand Up @@ -28,4 +28,5 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *

2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometryIdeal_cff.py
Expand Up @@ -6,6 +6,8 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsIdealGeometryXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

# Reconstruction geometry services
from Configuration.Geometry.GeometryReco_cff import *
1 change: 1 addition & 0 deletions Configuration/Geometry/python/GeometryNoCastor_cff.py
Expand Up @@ -28,3 +28,4 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *
2 changes: 1 addition & 1 deletion Configuration/Geometry/python/GeometryRecoDB_cff.py
Expand Up @@ -16,9 +16,9 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda - hcalParameters_cfi should not be included

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the hcalDDConstants_cff.py is already there in the IB of 2015-07-14-1100. I started from there.


From: Ianna Osborne [notifications@github.com]
Sent: 22 July 2015 12:10
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcs23 Modify to add the adequate ESProducers in the configuration scenarios (#10267)

In Configuration/Geometry/python/GeometryRecoDB_cff.pyhttps://github.com//pull/10267#discussion_r35198365:

@@ -16,9 +16,9 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
+from Geometry.HcalCommonData.hcalDDConstants_cff import *

@bsunandahttps://github.com/bsunanda - hcalParameters_cfi should not be included


Reply to this email directly or view it on GitHubhttps://github.com//pull/10267/files#r35198365.


# Alignment
from Geometry.TrackerGeometryBuilder.idealForDigiTrackerGeometryDB_cff import *
from Geometry.CSCGeometryBuilder.idealForDigiCscGeometryDB_cff import *
from Geometry.DTGeometryBuilder.idealForDigiDtGeometryDB_cff import *

1 change: 1 addition & 0 deletions Configuration/Geometry/python/GeometryRecoECALHCAL_cff.py
Expand Up @@ -6,6 +6,7 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *



Expand Down
1 change: 1 addition & 0 deletions Configuration/Geometry/python/GeometryRecoHCAL_cff.py
Expand Up @@ -4,5 +4,6 @@
from Geometry.CaloEventSetup.CaloTopology_cfi import *
from Geometry.CaloEventSetup.CaloGeometry_cff import *
CaloGeometryBuilder.SelectedCalos = ['HCAL', 'TOWER']
from Geometry.HcalCommonData.hcalDDConstants_cff import *


1 change: 1 addition & 0 deletions Configuration/Geometry/python/GeometryReco_cff.py
Expand Up @@ -24,4 +24,5 @@
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import *
from Geometry.EcalMapping.EcalMapping_cfi import *
from Geometry.EcalMapping.EcalMappingRecord_cfi import *
from Geometry.HcalCommonData.hcalDDConstants_cff import *

2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometrySLHCSimDB_cff.py
Expand Up @@ -7,3 +7,5 @@
from GeometryReaders.XMLIdealGeometryESSource.cmsGeometryDB_cff import *
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumbering2023GeometryDB_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda - this is not needed - the parameters should come from DB

from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometrySLHCSimIdeal_cff.py
Expand Up @@ -3,3 +3,5 @@
# Ideal geometry, needed for simulation
from SLHCUpgradeSimulations.Geometry.Phase1_R30F12_cmsSimIdealGeometryXML_cff import *
from Geometry.TrackerNumberingBuilder.trackerNumbering2023Geometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometrySimAll_cff.py
Expand Up @@ -3,3 +3,5 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsAllGeometryXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometrySimDB_cff.py
Expand Up @@ -7,3 +7,5 @@
from GeometryReaders.XMLIdealGeometryESSource.cmsGeometryDB_cff import *
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometryDB_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda - the same here, HcalParameters will be picked up from DB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated this PR taking care of Yana's comments. Can this PR be tested and integrated soon?


From: Ianna Osborne [notifications@github.com]
Sent: 20 July 2015 10:11
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcs23 Modify to add the adequate ESProducers in the configuration scenarios (#10267)

In Configuration/Geometry/python/GeometrySimDB_cff.pyhttps://github.com//pull/10267#discussion_r34974461:

@@ -7,3 +7,5 @@
from GeometryReaders.XMLIdealGeometryESSource.cmsGeometryDB_cff import *
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometryDB_cfi import *
+from Geometry.HcalCommonData.hcalParameters_cfi import *

@bsunandahttps://github.com/bsunanda - the same here, HcalParameters will be picked up from DB


Reply to this email directly or view it on GitHubhttps://github.com//pull/10267/files#r34974461.

from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometrySimECALHCAL_cff.py
Expand Up @@ -2,6 +2,8 @@

# Ideal geometry for ECAL+HCAL, needed for simulation
from Geometry.CMSCommonData.ecalhcalGeometryXML_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *



Expand Down
2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometrySimHCAL_cff.py
Expand Up @@ -2,6 +2,8 @@

# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.hcalOnlyGeometryXML_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *



2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometrySimIdealGFlash_cff.py
Expand Up @@ -3,4 +3,6 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsIdealGeometryGFlashXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *

2 changes: 2 additions & 0 deletions Configuration/Geometry/python/GeometrySimIdeal_cff.py
Expand Up @@ -3,3 +3,5 @@
# Ideal geometry, needed for simulation
from Geometry.CMSCommonData.cmsIdealGeometryXML_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import *
from Geometry.HcalCommonData.hcalParameters_cfi import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *