New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Run2-hcs23 Modify to add the adequate ESProducers in the configuration scenarios #10267
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,9 +16,9 @@ | |
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import * | ||
from Geometry.EcalMapping.EcalMapping_cfi import * | ||
from Geometry.EcalMapping.EcalMappingRecord_cfi import * | ||
from Geometry.HcalCommonData.hcalDDConstants_cff import * | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bsunanda - hcalParameters_cfi should not be included There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the hcalDDConstants_cff.py is already there in the IB of 2015-07-14-1100. I started from there. From: Ianna Osborne [notifications@github.com] In Configuration/Geometry/python/GeometryRecoDB_cff.pyhttps://github.com//pull/10267#discussion_r35198365:
@bsunandahttps://github.com/bsunanda - hcalParameters_cfi should not be included — |
||
|
||
# Alignment | ||
from Geometry.TrackerGeometryBuilder.idealForDigiTrackerGeometryDB_cff import * | ||
from Geometry.CSCGeometryBuilder.idealForDigiCscGeometryDB_cff import * | ||
from Geometry.DTGeometryBuilder.idealForDigiDtGeometryDB_cff import * | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,5 @@ | |
from GeometryReaders.XMLIdealGeometryESSource.cmsGeometryDB_cff import * | ||
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import * | ||
from Geometry.TrackerNumberingBuilder.trackerNumbering2023GeometryDB_cfi import * | ||
from Geometry.HcalCommonData.hcalParameters_cfi import * | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bsunanda - this is not needed - the parameters should come from DB |
||
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import * |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,5 @@ | |
from GeometryReaders.XMLIdealGeometryESSource.cmsGeometryDB_cff import * | ||
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import * | ||
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometryDB_cfi import * | ||
from Geometry.HcalCommonData.hcalParameters_cfi import * | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bsunanda - the same here, HcalParameters will be picked up from DB There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have updated this PR taking care of Yana's comments. Can this PR be tested and integrated soon? From: Ianna Osborne [notifications@github.com] In Configuration/Geometry/python/GeometrySimDB_cff.pyhttps://github.com//pull/10267#discussion_r34974461:
@bsunandahttps://github.com/bsunanda - the same here, HcalParameters will be picked up from DB — |
||
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda - which PR pre seeds this one? I do not see this configuration fragment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, it's in bsunanda/Run2-hcx22, but the definition in it is wrong for DB: hcalParameters_cfi should not be included in this case.