Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for running in unscheduled mode, rebased to 75X #10295

Merged
merged 2 commits into from Jul 28, 2015

Conversation

webermat
Copy link
Contributor

this is the 75X equivalent of PR #10289 superceding PR #9938 after rebasing.This should fix the issues observed in the unscheduled modes for MET Validation and JetMET DQM. As consequence the type1 MET folders will be renamed. Updated the PUJetID producers to the latest version (training still based on 53X though).

tested locally that both processes 1302 and 11325 finish successfully

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @webermat for CMSSW_7_5_X.

fix for running in unscheduled mode, rebased to 75X

It involves the following packages:

Configuration/StandardSequences
DQMOffline/JetMET
Validation/RecoMET

@cmsbuild, @danduggan, @franzoni, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmarionncern, @jdolen, @makortel, @rappoccio, @GiacomoSguazzoni, @TaiSakuma, @rovere, @VinInn, @Martin-Grunewald, @ahinzmann, @nhanvtran, @schoef, @cerati, @mariadalfonso, @dgulhan, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@webermat
Copy link
Contributor Author

a minor fix which explains unnatural peaks around 0 in plots a la https://goo.gl/dYQ91w
here we check that we have the PFCandidate species we fill present in the event. The check is implemented correct, but the name of the variable is not filled at the correct spot, but flipped (i.e. if the photon is in the minus endcap we fill the plus endcap pt_sum and vice versa).

@cmsbuild
Copy link
Contributor

Pull request #10295 was updated. @cmsbuild, @danduggan, @franzoni, @deguio, @davidlange6 can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Jul 23, 2015

+1

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jul 27, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Jul 28, 2015
fix for running in unscheduled mode, rebased to 75X
@davidlange6 davidlange6 merged commit e0cc726 into cms-sw:CMSSW_7_5_X Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants