Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert PFEGAlgo to use GlobalCache + GBRForest #10410

Merged
merged 1 commit into from Jul 31, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jul 28, 2015

Meanwhile at the Legion of Doom Headquarters...

Same thing as for GsfElectronAlgo (#10327), except this time for PFEGAlgo.
Expect modest memory improvements, no changes to physics output other than possible jitter.

Note, once all of these are integrated we should see a rather healthy decrease in the amount of time it takes for multicore jobs to start. May be something to look at later.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X.

Convert PFEGAlgo to use GlobalCache + GBRForest

It involves the following packages:

RecoParticleFlow/PFProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jul 28, 2015

@cmsbuild please test

@Dr15Jones
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor

I now have the old Justice League of America theme song running through my head

@cmsbuild
Copy link
Contributor

@lgray
Copy link
Contributor Author

lgray commented Jul 28, 2015

@Dr15Jones I do what I can to bring enjoyment to your day. :-)

@cvuosalo
Copy link
Contributor

Memory usage measurement in progress...

@cvuosalo
Copy link
Contributor

+1

For #10410 ea54aac

Converting PFEGAlgo to use GlobalCache + GBRForest to reduce memory use. There should be no significant change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-07-27-2300 show no significant differences, as expected.
RECO for workflow 25202.0_TTbar_13 with 70 events and no DQM or Validation against baseline CMSSW_7_6_0_pre2 shows about a 45 MB reduction in RSS:

Baseline
Max VSIZ 1859.43 on evt 57 ; max RSS 1616.96 on evt 57
Time av 15.111 s/evt max 37.8596 s on evt 57
M1 Time av 14.7895 s/evt max 37.8596 s on evt 57

PR 10410
Max VSIZ 1849.94 on evt 57 ; max RSS 1571.54 on evt 57
Time av 15.0332 s/evt max 37.2437 s on evt 57
M1 Time av 14.7164 s/evt max 37.2437 s on evt 57

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants