Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of HLT b-tag validation code in 74X #10493

Merged
merged 4 commits into from Aug 11, 2015

Conversation

silviodonato
Copy link
Contributor

This PR basically sync the 74X HLT b-tag validation code with the 75X version.
The only difference is about the trigger names.
Here the names that are different are:

  • HLT_CaloMHTNoPU90_PFMET90_PFMHT90_ID
  • HLT_PFMET120_NoiseCleaned_BTag

In this way we get a validation code that is compatible both with the old HLT menu (eg. HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDLoose_v1) and with the new one (eg. eg. HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_v1)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato for CMSSW_7_4_X.

Update of HLT b-tag validation code in 74X

It involves the following packages:

HLTriggerOffline/Btag

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Aug 5, 2015

please test

@deguio
Copy link
Contributor

deguio commented Aug 5, 2015

+1
seems ok to me

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 11, 2015
Update of HLT b-tag validation code in 74X
@cmsbuild cmsbuild merged commit f3cbc0f into cms-sw:CMSSW_7_4_X Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants