New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factorise PreSplitting configuration from InitialStep #10580
Factorise PreSplitting configuration from InitialStep #10580
Conversation
…that they can be tuned independently. Fix order of python import logic. No regression expected.
A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_6_X. Factorise PreSplitting configuration from InitialStep It involves the following packages: RecoTracker/IterativeTracking @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 DAS Error 4.53 step1 DAS Error 140.53 step1 DAS Error you can see the results of the tests here: |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 For Tracking, factorizing PreSplitting configuration from the InitialStep. This code improvement to facilitate tuning should have no effect on monitored quantities. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-08-07-1100 show no significant differences, as expected. A check of the expanded RECO config of workflow 25202.0 confirms the new pre-splitting is included. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…Estimator Factorise PreSplitting configuration from InitialStep
Completely factorise PreSplitting from InitialStep configuration, so that they can be tuned independently. Fix order of python import logic. No regression expected.