Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorise PreSplitting configuration from InitialStep #10580

Merged

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Aug 5, 2015

Completely factorise PreSplitting from InitialStep configuration, so that they can be tuned independently. Fix order of python import logic. No regression expected.

…that they can be tuned independently. Fix order of python import logic. No regression expected.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_6_X.

Factorise PreSplitting configuration from InitialStep

It involves the following packages:

RecoTracker/IterativeTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @VinInn, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Aug 5, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

@slava77
Copy link
Contributor

slava77 commented Aug 7, 2015

@cmsbuild please test
Last time the comparisons never completed

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

-1
Tested at: 8c920bc
When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error

4.53 step1

DAS Error

140.53 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10580/5320/summary.html

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 7, 2015

@cmsbuild please test
Hope the DAS errors are transient

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 8, 2015

+1

For #10580 8c920bc

For Tracking, factorizing PreSplitting configuration from the InitialStep. This code improvement to facilitate tuning should have no effect on monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-08-07-1100 show no significant differences, as expected. A check of the expanded RECO config of workflow 25202.0 confirms the new pre-splitting is included.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 8, 2015
…Estimator

Factorise PreSplitting configuration from InitialStep
@cmsbuild cmsbuild merged commit fea2b18 into cms-sw:CMSSW_7_6_X Aug 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants