Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EGM IDs for MiniAOD Reprocessing (76X) #10619

Merged
merged 31 commits into from Aug 15, 2015
Merged

EGM IDs for MiniAOD Reprocessing (76X) #10619

merged 31 commits into from Aug 15, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Aug 7, 2015

Forward port of #10598.

Depends on #10618.

Weight files are absent from this PR.

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Aug 7, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X.

EGM IDs for MiniAOD Reprocessing (76X)

It involves the following packages:

DataFormats/EgammaCandidates
PhysicsTools/PatAlgos
PhysicsTools/SelectorUtils
RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @imarches, @ahinzmann, @acaudron, @mmarionncern, @TaiSakuma, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor Author

lgray commented Aug 7, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

+1
Tested at: 25ff168
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10619/193985/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10619/193985/summary.html

slava77
slava77 reviewed Aug 12, 2015
View reviewed changes
PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py
switchOnVIDElectronIdProducer(process,DataFormat.MiniAOD)
process.egmGsfElectronIDs.physicsObjectSrc = \
cms.InputTag("reducedEgamma","reducedGedGsfElectrons")
process.electronMVAValueMapProducer.src = \
cms.InputTag('reducedEgamma','reducedGedGsfElectrons')
for idmod in electron_ids:
setupAllVIDIdsInModule(process,idmod,setupVIDElectronSelection)
setupAllVIDIdsInModule(process,idmod,setupVIDElectronSelection,None,False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False means not to add to UserData? Where do these values go then? just empty space or are they consumed somewhere (lazy to parse the underlying code)

@slava77
Copy link
Contributor

slava77 commented Aug 12, 2015

it may help review if this one is rebased
.. otherwise, diffs need to be done manually/locally
... I managed to do a mix, so, it wouldn't be for me at this point.

... running short++ matrix now

@lgray
Copy link
Contributor Author

lgray commented Aug 12, 2015

@slava77 ok I'll rebase it in a bit

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@lgray
Copy link
Contributor Author

lgray commented Aug 13, 2015

Nope DAS is still dead for jenkins it seems. The present test will fail.

@slava77
Copy link
Contributor

slava77 commented Aug 13, 2015

+1

for #10619 6b8b134

  • code changed and updated following the code review as expected
  • warnings about incorrect md5 values are gone
  • tested locally in CMSSW_7_6_0_pre3 /test area sign579 (latest commits were cherry-picked)/

@cmsbuild
Copy link
Contributor

-1

Tested at: 6b8b134
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10619/7248/summary.html

@slava77 slava77 mentioned this pull request Aug 14, 2015
Closed
@lgray
Copy link
Contributor Author

lgray commented Aug 14, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 6b8b134
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10619/7265/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10619/7265/summary.html

davidlange6 added a commit that referenced this pull request Aug 15, 2015
@davidlange6
Merge pull request #10619 from lgray/egm_id_76X_v1
e470356 
EGM IDs for MiniAOD Reprocessing (76X)
@davidlange6 davidlange6 merged commit e470356 into cms-sw:CMSSW_7_6_X Aug 15, 2015
@slava77 slava77 mentioned this pull request Aug 16, 2015
Closed
@diguida diguida mentioned this pull request Aug 17, 2015
Merged
@lgray lgray mentioned this pull request Aug 20, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available orp-pending pending-signatures reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lgray @cmsbuild @slava77 @davidlange6 @ikrav @skyriacoCMS