-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EGM IDs for MiniAOD Reprocessing (76X) #10619
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
2086e1e
New MVA IDs from Rong-Shyang for Spring15: V1 for 50ns and V0 for 25ns
ikrav e996ba4
Added the mvaTag field to the MVA estimator, plus dependencies, to di…
ikrav f1a120b
Added the new mvaTag field to the most recent MVA configuratoins
ikrav 2da2fc0
Create effAreaNeutralHadrons_cone03_pf_50ns.txt
skyriacoCMS 741e2da
Create effAreaPhotons_cone03_pfPhotons_50ns.txt
skyriacoCMS 9466895
Create effAreaPhotons_cone03_pfChargedHadrons_50ns.txt
skyriacoCMS 1924ecc
Rename effAreaNeutralHadrons_cone03_pf_50ns.txt to effAreaPhotons_con…
skyriacoCMS 1a8a545
Create cutBasedPhotonID_Spring15_50ns_V1_cff.py
skyriacoCMS 79d0aff
New effective areas for electrons for Spring15 25ns abd 50ns
ikrav e95543c
The implementation of the new 25ns non-triggering MVA tuned by P.Piga…
ikrav f816829
Renamed the two files of the new Spring15 electron non-trig MVA into …
ikrav cd64007
Weights and new python configuration for the new non-trig 25ns Spring…
ikrav 4dc31fa
A few fixes
ikrav 49a174f
a change to the Reader options
ikrav a73b3f9
update Spring15NonTrig for electrons to threadsafe base class
lgray 60422e0
Spring15 50ns ID from 31072015 presentation (Rami)
lgray f9241dc
Set Spring15_25ns MVA to actual values for WP90 from P. Pigard
lgray 198e4fe
add 50ns mva Photon ID V2
lgray be687e5
Fix implementation of @skyriacoCMS photon ID, fix bug in lower level …
lgray 9570aa1
update MiniAOD tools to the latest EGM-blessed IDs
lgray 4c5b513
invalidate deprecated IDs
lgray f47d04a
fix typos in Spring15 ID cutbased, validation now checks out
lgray a4f6e1d
remove HEEP51 from MiniAOD and deprecate it
lgray ae12245
turn off embedding of vid::CutFlowResult in MiniAOD pat candidates
lgray 00d738d
EGM Object Modifiers for MiniAOD reprocessing
lgray 9a476f2
add wp80 to Spring15 electron mva ID
lgray c5e0dba
add in embedding control from 74X to 75X to vid tools
lgray 474e386
correct the ID MD5 hashes
lgray fd940bb
use constants instead of magic numbers eta cut
lgray 6a6336a
fix semicolon;
lgray 6b8b134
reduce copy/pasta in IsolationModifier
lgray File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,9 +80,11 @@ MVAValueMapProducer<ParticleType>::MVAValueMapProducer(const edm::ParameterSet& | |
// | ||
// Compose and save the names of the value maps to be produced | ||
// | ||
//const auto& currentEstimator = mvaItr->second; | ||
const std::string thisValueMapName = mvaItr->first + "Values"; | ||
const std::string thisCategoriesMapName = mvaItr->first + "Categories"; | ||
const auto& currentEstimator = mvaItr->second; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah, that's where it was needed ... |
||
const std::string full_name = ( currentEstimator->getName() + | ||
currentEstimator->getTag() ); | ||
std::string thisValueMapName = full_name + "Values"; | ||
std::string thisCategoriesMapName = full_name + "Categories"; | ||
mvaValueMapNames_.push_back( thisValueMapName ); | ||
mvaCategoriesMapNames_.push_back( thisCategoriesMapName ); | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
False means not to add to UserData? Where do these values go then? just empty space or are they consumed somewhere (lazy to parse the underlying code)