Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HF Minimum Bias algorithm to Stage1 Emulator #10695

Merged

Conversation

harmonicoscillator
Copy link
Contributor

Due to changes in how the minimum bias bits are handled with respect to legacy, the Layer2 emulator needs to handle the minimum bias bits which are transmitted on the HF Bit Counts fiber.

This PR adds the required changes to the Layer2, but because of an upsteam issue with the HCAL digis, only real-data will have non-zero values for this. MC requires a near-future PR to have non-zero Minimum bias bits.

This algorithm was tested against the currently running L1 Firmware by Ben Kreis and I.

@mulhearn You should probably sign off on this.

Expect to see backport PRs for 75X and 74X shortly.

@harmonicoscillator
Copy link
Contributor Author

#10696 is the 75X backport, and #10697 is the 74X backport.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_6_X.

Add HF Minimum Bias algorithm to Stage1 Emulator

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@harmonicoscillator
Copy link
Contributor Author

@icali Wanted to be linked in.

@harmonicoscillator
Copy link
Contributor Author

This is fairly urgent, since we are currently taking data using this algorithm in firmware with no matching emulator algorithm. @mulhearn Is there a plan moving forward for this algorithm?

@mulhearn
Copy link
Contributor

please test

@mulhearn
Copy link
Contributor

Sorry, Alex, was traveling and missed this one...

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@mulhearn
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@mulhearn
Copy link
Contributor

mulhearn commented Sep 1, 2015

please test

@mulhearn
Copy link
Contributor

mulhearn commented Sep 1, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 2, 2015
Add HF Minimum Bias algorithm to Stage1 Emulator
@cmsbuild cmsbuild merged commit 6acf0f1 into cms-sw:CMSSW_7_6_X Sep 2, 2015
cmsbuild added a commit that referenced this pull request Sep 27, 2015
 Add HF Minimum Bias algorithm to Stage1 Emulator (backport 74X #10695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants