Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APE tool implemented, PR 10601 backported #10892

Merged
merged 10 commits into from Nov 10, 2015

Conversation

cschomak
Copy link
Contributor

PR #10601 backported to 75X
APE tool implemented into the release
TrackerTreeGenerator (necessary for the APE tool, but might also used for other purposes) included in Alignment/TrackerAlignment
Fixes for ApeSettingAlgorithm in CommonAlignmentAlgorithm and AlignmentProducer in CommonAlignmentProducer

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cschomak for CMSSW_7_5_X.

APE tool implemented, PR 10601 backported

It involves the following packages:

Alignment/APEEstimation
Alignment/CommonAlignmentAlgorithm
Alignment/CommonAlignmentProducer
Alignment/TrackerAlignment

The following packages do not have a category, yet:

Alignment/APEEstimation

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Aug 21, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 9f61d2e
When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error

140.53 step1

DAS Error

1000.0 step1

DAS Error

1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10892/7531/summary.html

@cschomak
Copy link
Contributor Author

cschomak commented Sep 3, 2015

Same here as in PR 10893, I suppose

@mmusich
Copy link
Contributor

mmusich commented Sep 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2015

+1

davidlange6 added a commit that referenced this pull request Nov 10, 2015
APE tool implemented, PR 10601 backported
@davidlange6 davidlange6 merged commit cb38302 into cms-sw:CMSSW_7_5_X Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants