Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valid,lost,missing inner/outer hits 2d-histos #11027

Merged
merged 11 commits into from Sep 27, 2015

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Aug 29, 2015

add valid,lost,missing inner/outer hits 2d-histos to tracking dqm.
added Ntrack vs Nvtx as well

makes sense only if integrated in production before end of TS2

please refer to https://its.cern.ch/jira/browse/CMSTRACK-139
for more details

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_4_X.

Add valid,lost,missing inner/outer hits 2d-histos

It involves the following packages:

DQM/TrackingMonitor

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@makortel, @threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #11027 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@VinInn
Copy link
Contributor Author

VinInn commented Sep 1, 2015

@cmsbuild please test

fix booking protection
@VinInn
Copy link
Contributor Author

VinInn commented Sep 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

Pull request #11027 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Sep 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

The tests are being triggered in jenkins.

protect against missing vertex collection
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

-1
Tested at: 42214b8
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11027/7815/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

Pull request #11027 was updated. @danduggan, @deguio can you please check and sign again.

@VinInn
Copy link
Contributor Author

VinInn commented Sep 3, 2015

please test again
140.53 failure is fixed by last commit

@davidlange6
Copy link
Contributor

@cmsbuild, please test

On Sep 3, 2015, at 9:35 AM, Vincenzo Innocente notifications@github.com wrote:

please test again
140.53 failure is fixed by last commit


Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

@VinInn
Copy link
Contributor Author

VinInn commented Sep 10, 2015

I have a very serious problem in understanding why this PR did not make it in 7_4_12 despite the clear message that TRK-POG needs this starting next Run at 3.8T.
same for the companion #11026

@deguio
Copy link
Contributor

deguio commented Sep 11, 2015

+1
I guess it is my fault. too many PR and too few people checking them. sorry @VinInn

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 27, 2015
Add valid,lost,missing inner/outer hits 2d-histos
@cmsbuild cmsbuild merged commit 3f2d9c4 into cms-sw:CMSSW_7_4_X Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants