Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron object modifier 75X #11160

Merged

Conversation

matteosan1
Copy link
Contributor

Same as 11126 and 11139 to roll-back egammaObjectModifier configuration.
This PR has been done on top of 11118 by @arizzi.

ikrav and others added 30 commits September 1, 2015 14:33
…stinguish different cases of the MVA of the same class configured with different weights/tunings.
…rd, the C++ part. The Python part is yet to come.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2015

A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_5_X.

Electron object modifier 75X

It involves the following packages:

DataFormats/EgammaCandidates
PhysicsTools/PatAlgos
PhysicsTools/SelectorUtils
RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @imarches, @ahinzmann, @acaudron, @mmarionncern, @TaiSakuma, @lgray, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor

lgray commented Sep 6, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2015

@slava77
Copy link
Contributor

slava77 commented Sep 10, 2015

+1

for #11160 49ffe7e

@slava77
Copy link
Contributor

slava77 commented Sep 10, 2015

@monttj please check if it's ok from your side

davidlange6 added a commit that referenced this pull request Sep 11, 2015
@davidlange6 davidlange6 merged commit 2aadff2 into cms-sw:CMSSW_7_5_X Sep 11, 2015
@matteosan1 matteosan1 deleted the electronObjectModifier_75X_for_arizzi branch October 5, 2015 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants