Replace LinkDef files with XML selextion files.in CalibCalorimetry/EcalLaserAnalyzer

[wmtan]

It has been decided to replace LinkDef files with XML selection files.
This PR does this for the LinkDef files that were in CalibCalorimetry/EcalLaserAnalyzer.
A reorganization of existing files was needed because XML selection files are not allowed in plugins.
LinkDef files should not be in plugins, either, but that was never enforced.

[cmsbuild]

A new Pull Request was created by @wmtan for CMSSW_7_6_X.

Replace LinkDef files with XML selextion files.in CalibCalorimetry/EcalLaserAnalyzer

It involves the following packages:

CalibCalorimetry/EcalLaserAnalyzer

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[wmtan]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8697/console

[cmsbuild]

-1

Tested at: c6598c4
I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:50nsGRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_50nsGRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_50ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_50nsGRun_DATA.root --fileout file:RelVal_Raw_50nsGRun_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 18:39:24 2015-date Thu Oct 8 18:32:59 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 18:51:03 2015-date Thu Oct 8 18:46:29 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 18:57:03 2015-date Thu Oct 8 18:52:03 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11673/8697/summary.html

[wmtan]

@cmsbuild
These three add-on tests fail in the base IB, so are not caused by this PR. Please mark the tests as approved.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11673/8697/summary.html

[wmtan]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8731/console

[cmsbuild]

+1
Tested at: c6598c4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11673/8731/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11673/8731/summary.html

[wmtan]

@diguida, @franzoni, @cerminar
Please sign or provide a reason for not signing

[mmusich]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[davidlt]

@wmtan I see build failures in CalibCalorimetry/EcalLaserAnalyzer package in CMSSW_7_6_DEVEL_X_2015-10-12-2300 (ROOT 6.04).

Error in <PulseFitWithFunction>: PulseFitWithFunction inherits from TObject but does not have its own ClassDef
Error in <PulseFitWithShape>: PulseFitWithShape inherits from TObject but does not have its own ClassDef
Error in <TFParams>: TFParams inherits from TObject but does not have its own ClassDef
Error in <TMarkov>: TMarkov inherits from TObject but does not have its own ClassDef
Error in <TMatacq>: TMatacq inherits from TObject but does not have its own ClassDef
Error in <TPNFit>: TPNFit inherits from TObject but does not have its own ClassDef
Error in <TPNCor>: TPNCor inherits from TObject but does not have its own ClassDef
Error in <TSFit>: TSFit inherits from TObject but does not have its own ClassDef
Error in <TShapeAnalysis>: TShapeAnalysis inherits from TObject but does not have its own ClassDef
Error in <TMom>: TMom inherits from TObject but does not have its own ClassDef
Error in <TAPDPulse>: TAPDPulse inherits from TObject but does not have its own ClassDef
Error in <TPNPulse>: TPNPulse inherits from TObject but does not have its own ClassDef
Error in <TMem>: TMem inherits from TObject but does not have its own ClassDef

[wmtan]

@davidlt Those messages are non-fatal, and were already there with the LinkDef file, so they were not introduced by this PR. Since I don't own those classes, I hesitate to add a ClassDef().

[davidlt]

It's fixed in ROOT 6.04 and they are fatal. A number of these classes contain commented out ClassDef lines, which are required. I can make a PR tomorrow.

[davidlt]

RFC: #11787