b-tag GBRForest payloads from GT

[ferencek]

This PR enables fetching the b-tag GBRForest payloads from the global tag. In addition, the pfCombinedMVAv2 tagger is now added to PAT jets by default.

@jpata, it appears that the AdaBoost flag for the CombinedMVAv2 taggers was not set correctly. Please check that everything is configured correctly in the PR.

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_6_X.

b-tag GBRForest payloads from GT

It involves the following packages:

CommonTools/Utils
PhysicsTools/PatAlgos
RecoBTag/Combined
RecoBTag/SoftLepton

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @jdolen, @imarches, @makortel, @acaudron, @mmarionncern, @rappoccio, @ahinzmann, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test
[unclear if it makes it to pre7]

[cmsbuild]

The tests are being triggered in jenkins.
JENKINS_TEST_URL

[cmsbuild]

-1

Tested at: d4c0c35
I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:50nsGRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_50nsGRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_50ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_50nsGRun_DATA.root --fileout file:RelVal_Raw_50nsGRun_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 09:39:19 2015-date Thu Oct 8 09:35:41 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 09:47:01 2015-date Thu Oct 8 09:44:32 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 09:53:19 2015-date Thu Oct 8 09:49:25 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11685/8683/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11685/8683/summary.html

[slava77]

+1

for #11685 d4c0c35

• code changes are mostly in line with the descripsion
  • @ferencek it's worth to add that the pfCombinedMVAV2BJetTags is now added to the taggers saved with pat jets
• jenkins test pass and show differences only in plots related to pfCombinedMVAV2BJetTags

Comparing to baseline (CMSSW_7_6_X_2015-10-08-1100) in local tests:

• there is a noticeable change in pfCombinedMVAV2BJetTags (e.g. 251721 DoubleMuon)

and the same just with value>=0: the tagger values now run only up to 1.0

On the technical side:

• there is apparently 485 kB of additional allocations through DB reads of GBRForest, but this is probably from the change of the origin, which is not easy to get to
• pfCombinedMVAV2BJetTagsAK8 and pfCombinedMVAV2BJetTagsPuppi are now running in the default calls with pat/miniaod steps (a result of the change in PhysicsTools/PatAlgos/python/producersLayer1/jetProducer_cfi.py) ; there is also a small increase in size of slimmedJets and slimmedJetsPuppi
• there is no significant change in size on disk or CPU time (the new modules take up under 2 ms /evt)

[ferencek]

@slava77, I updated the PR description and mentioned the addition of pfCombinedMVAV2BJetTags.

@jpata, can you please comment on the discriminator changes. What was in the release before this PR was not producing values between -1 and 1. However, if I switched back to just using TMVA (no GBRForest), I would get values between -1 and 1. So it appeared that the GBRForest AdaBoost flag was not set correctly resulting in discriminator values that went beyond -1 and 1. Now the GBRForest output matches with that from TMVA.

[ferencek]

@monttj, can you please sign this PR. Thanks

[jpata]

@jpata, it appears that the AdaBoost flag for the CombinedMVAv2 taggers was not set correctly. Please check that everything is configured correctly in the PR.

@ferencek you are completely correct, the AdaBoost flag should be changed to False as you did. I didn't manage propagate this. Sorry for the delay in answering, I had not seen the original mail(s).

[ferencek]

@jpata, thanks for the reply. At this point there are no outstanding issues and the test errors appear unrelated to this PR.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8866/console

[cmsbuild]

+1
Tested at: d4c0c35
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11685/8866/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11685/8866/summary.html