Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add castor geometry files with position for 2015 #11730

Merged
merged 1 commit into from Jan 24, 2016

Conversation

cbaus
Copy link

@cbaus cbaus commented Oct 12, 2015

This PR is complementary to the other two recent PRs for CASTOR (#10259, #10216).
The changed add 3 castor.xml files:

  1. One with the measured position by the positioning sensors
  2. Same as (1) plus an upward shift within the sys uncertainty
  3. Same as (2) but with downward shift.

The files are in separate folders. Hope this is OK but simple renaming could not be done because of the namespace "castor:" used by DDL.

FSQ Group wants to request simulations with these files.
Thank you.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cbaus for CMSSW_7_6_X.

Add castor geometry files with position for 2015

It involves the following packages:

Geometry/ForwardCommonData

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Oct 12, 2015

@cmsbuild - please test

@ianna
Copy link
Contributor

ianna commented Oct 12, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8767/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Oct 13, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6 davidlange6 merged commit 767ead1 into cms-sw:CMSSW_7_6_X Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants