Add possibility for partial ECAL digitization (towards working HGCAL) #11784

lgray · 2015-10-14T10:29:42Z

Add in options to turn off EB/EE/ES in ECAL digitizer, default all on.
Also, some modernization of code.

This change is technical in nature.

lgray · 2015-10-14T10:31:07Z

@vandreev11 @pfs @cseez @kpedro88 @sethzenz @bsunanda FYI

cmsbuild · 2015-10-14T10:36:12Z

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X.

Add possibility for partial ECAL digitization (towards working HGCAL)

It involves the following packages:

SimCalorimetry/EcalSimProducers

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

civanch · 2015-10-14T12:08:30Z

please test

cmsbuild · 2015-10-14T12:11:24Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8834/console

lgray · 2015-10-14T12:12:41Z

@civanch FYI IBs are broken right now, tests will fail.

cmsbuild · 2015-10-14T12:29:20Z

-1
Tested at: 2233d7b
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11784/8834/summary.html

lgray · 2015-10-14T12:36:52Z

Ah, good a whole bunch of clang errors to fix. Will do that.

argiro · 2015-10-14T14:04:26Z

@lgray,

I believe this is just adding the possibility to switch EE/EB/ES digitization on/off, right ?
If not , it would be great if you could you tell us ECAL-ers a bit more about this PR.

thanks, S.

On 14 Oct 2015, at 12:36, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X.

Add possibility for partial ECAL digitization (towards working HGCAL)

It involves the following packages:

SimCalorimetry/EcalSimProducers

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

—
Reply to this email directly or view it on GitHub.

lgray · 2015-10-14T14:05:40Z

@argiro Yes, correct, it just adds this switching capability. It changes bare pointers to use std::unique_ptr where appropriate. Nothing more.

smuzaffar · 2015-10-14T19:44:21Z

please test

cmsbuild · 2015-10-14T19:56:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8855/console

cmsbuild · 2015-10-14T21:07:19Z

-1
Tested at: 2233d7b
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 14-Oct-2015 22:15:31 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 14-Oct-2015 22:17:34 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 14-Oct-2015 22:20:46 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 14-Oct-2015 22:22:36 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 14-Oct-2015 22:23:26 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 14-Oct-2015 22:25:53 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
----- Begin Fatal Exception 14-Oct-2015 22:26:34 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 14-Oct-2015 22:28:45 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log
----- Begin Fatal Exception 14-Oct-2015 22:30:54 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 14-Oct-2015 22:30:53 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 14-Oct-2015 22:32:50 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 14-Oct-2015 22:41:57 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 14-Oct-2015 22:45:25 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11784/8855/summary.html

lgray · 2015-10-14T21:11:13Z

Will fix up tomorrow.

lgray · 2015-10-15T08:31:38Z

@cmsbuild please test

cmsbuild · 2015-10-15T08:36:25Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8893/console

cmsbuild · 2015-10-15T10:03:22Z

+1
Tested at: 08e0e13
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11784/8892/summary.html

cmsbuild · 2015-10-15T10:18:08Z

+1
Tested at: 08e0e13
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11784/8893/summary.html

cmsbuild · 2015-10-15T11:11:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11784/8892/summary.html

cmsbuild · 2015-10-15T11:24:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11784/8893/summary.html

civanch · 2015-10-15T13:18:27Z

+1

cmsbuild · 2015-10-15T13:21:42Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

lgray · 2015-10-19T07:55:42Z

Would be nice to get this one in here or in 80X. Either is fine. Thanks!

davidlange6 · 2015-10-19T10:01:54Z

+1

Add possibility for partial ECAL digitization (towards working HGCAL)

smuzaffar · 2015-10-21T12:09:59Z

@lgray , could this PR be the reason of following failure in IBs relval tests

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc493/CMSSW_8_0_X_2015-10-20-1100/pyRelValMatrixLogs/run/250407.0_NUGUN_UP15+FS_NuGun_UP15_PRMXUP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS/step1_NUGUN_UP15+FS_NuGun_UP15_PRMXUP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS.log
MissingParameter: Parameter 'doEB' not found.

lgray · 2015-10-21T12:12:29Z

@smuzaffar Yes, that's related to this PR. It's really weird that the other fastsim workflows function... I'll take a look and provide a fix.

Add in options to turn off EB/EE/ES in ECAL digitizer, default all on

2233d7b

cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 14, 2015

cmsbuild added simulation-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 14, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 14, 2015

cmsbuild added tests-rejected and removed tests-started labels Oct 14, 2015

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Oct 14, 2015

cmsbuild added tests-rejected and removed tests-started labels Oct 14, 2015

cmsbuild added tests-pending and removed tests-started labels Oct 15, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 15, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 15, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 15, 2015

cmsbuild added simulation-approved fully-signed and removed pending-signatures simulation-pending labels Oct 15, 2015

lgray mentioned this pull request Oct 16, 2015

HGC ToT Digitization Implementation (and corresponding RECO updates) #11850

Closed

cmsbuild mentioned this pull request Oct 19, 2015

Add possibility for partial ECAL digitization (towards working HGCAL) #11915

Merged

cmsbuild added orp-approved and removed orp-pending labels Oct 19, 2015

cmsbuild added a commit that referenced this pull request Oct 19, 2015

Merge pull request #11784 from lgray/allow_partial_ecal_digi

3bbe62a

Add possibility for partial ECAL digitization (towards working HGCAL)

cmsbuild merged commit 3bbe62a into cms-sw:CMSSW_7_6_X Oct 19, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add possibility for partial ECAL digitization (towards working HGCAL) #11784

Add possibility for partial ECAL digitization (towards working HGCAL) #11784

lgray commented Oct 14, 2015

lgray commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

civanch commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

lgray commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

lgray commented Oct 14, 2015

argiro commented Oct 14, 2015

lgray commented Oct 14, 2015

smuzaffar commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

lgray commented Oct 14, 2015

lgray commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

civanch commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

lgray commented Oct 19, 2015

davidlange6 commented Oct 19, 2015

smuzaffar commented Oct 21, 2015

lgray commented Oct 21, 2015

Add possibility for partial ECAL digitization (towards working HGCAL) #11784

Add possibility for partial ECAL digitization (towards working HGCAL) #11784

Conversation

lgray commented Oct 14, 2015

lgray commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

civanch commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

lgray commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

lgray commented Oct 14, 2015

argiro commented Oct 14, 2015

lgray commented Oct 14, 2015

smuzaffar commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

lgray commented Oct 14, 2015

lgray commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

civanch commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

lgray commented Oct 19, 2015

davidlange6 commented Oct 19, 2015

smuzaffar commented Oct 21, 2015

lgray commented Oct 21, 2015