bugfix: assign muon PDG id using PFMuon charge

[jhgoh]

This PR is a bugfix for inconsistent PDG id assignment in the MuonProducer.

The MuonProducer sets variables from the PF muon but the PDG ID was omitted. Inconsistency between sign of pdg id and charge is spotted by Nicola;

event 1:19778:3823145

/store/mc/RunIISpring15DR74/ZZTo4L_13TeV_powheg_pythia8/MINIAODSIM/Asympt25ns_MCRUN2_74_V9-v1/10000/A43364CC-1C17-E511-AEF2-00266CFAE8C4.root

has a muon with pT=38.6605, charge -1, pdgId=-13 (mu+), muonBestTrackType=4.

[cmsbuild]

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_7_6_X.

bugfix: assign muon PDG id using PFMuon charge

It involves the following packages:

RecoMuon/MuonIdentification

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @bellan, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@jhgoh
Do I understand it correctly, that we didn't notice this bug with all of the run1 8 TeV data analyses?

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8939/console

[slava77]

... ok, the bug was not there yet in 53X release

[cmsbuild]

+1
Tested at: ff79640
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11838/8939/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11838/8939/summary.html

[cvuosalo]

+1

For #11838 ff79640

Fixing rare case where muon PDG ID had reversed sign.

The code fix is satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-10-15-2300 show no significant differences.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1