Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METfilters: fix forth bad EE supercluster #12034

Merged
merged 1 commit into from Oct 27, 2015

Conversation

mariadalfonso
Copy link
Contributor

This PR refine one MET filter adding one bad SC to the list. See finding / validation in
https://hypernews.cern.ch/HyperNews/CMS/get/ecal-performance/839/2/1.html
We aim to have in the 76 re-reco of the data
@schoef

@mariadalfonso mariadalfonso changed the title fix forth bad EE supercluster METfilters: fix forth bad EE supercluster Oct 21, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 21, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mariadalfonso for CMSSW_7_6_X.

METfilters: fix forth bad EE supercluster

It involves the following packages:

RecoMET/METFilters

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 21, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9116/console

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 22, 2015

Maria,
if I understand correctly, the MET filter decisions are not monitored in DQM/Validation.
If that's correct, why not?

@mariadalfonso
Copy link
Contributor Author

@slava77 @webermat
Hi Slava. For now in the DQM we have two histograms of pfMET (with the filters applied and not), matthias knows the details. This should be enough for the data quality monitors of the runs. For the release integration do you desire to have histograms to monitor the pass fails for each of the standard filters (HBHE, HBHEIso, EESC, CSCTigh2015)?

@slava77
Copy link
Contributor

slava77 commented Oct 22, 2015

I think that ta a histogram with filter pass/fail count would be useful
(it could be just one histogram for all filters with pass counts filled; could be separate histograms with 2-bin pass/fail).
Memory-wise, one histogram with a bin per filter would be better.

@mariadalfonso
Copy link
Contributor Author

@slava77 @webermat
ok, the DQM modification you propose can be added in the pending DQM update
#11539
and in the meanwhile I propose to go with the merging of this PR

@slava77
Copy link
Contributor

slava77 commented Oct 22, 2015

I checked jenkins outputs and observe no difference.
This just says the problematic cell shows up rarely enough.
This PR has no RECO signature requirement (maybe it eventually should, since this code is a part of RECO+miniAOD workflow).
It looks fine for me.

@davidlange6

davidlange6 added a commit that referenced this pull request Oct 27, 2015
METfilters: fix forth bad EE supercluster
@davidlange6 davidlange6 merged commit d8994fa into cms-sw:CMSSW_7_6_X Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants