Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CalibCalorimetry/EcalLaserAnalyzer: disable object I/O (ClassDef) #12115

Merged
merged 1 commit into from Oct 27, 2015
Merged

CalibCalorimetry/EcalLaserAnalyzer: disable object I/O (ClassDef) #12115

merged 1 commit into from Oct 27, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Oct 27, 2015

Having classes based on TObject without ClassDef creates issues while
creating a dictionary. According to CVS these files were introduced 6
years and 4 months ago and already had ClassDef commented out.
ClassVersionID is set to 0 because I/O is not needed for these
control classes.

CVS history:http://cvs.web.cern.ch/cvs/cgi-bin/viewcvs.cgi/CMSSW/CalibCalorimetry/EcalLaserAnalyzer/interface/
ROOT ClassDef documentation: https://root.cern.ch/root/Using.html

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

CalibCalorimetry/EcalLaserAnalyzer: disable object I/O (ClassDef)
f301c35 
Having classes based on `TObject` without `ClassDef` creates issues while
creating a dictionary. According to CVS these files were introduced 6
years and 4 months ago and already had `ClassDef` commented out.
`ClassVersionID` is set to **0** because I/O is not needed for these
control classes.

CVS history:http://cvs.web.cern.ch/cvs/cgi-bin/viewcvs.cgi/CMSSW/CalibCalorimetry/EcalLaserAnalyzer/interface/
ROOT `ClassDef` documentation: https://root.cern.ch/root/Using.html

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@davidlt davidlt mentioned this pull request Oct 27, 2015
Closed
@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Oct 27, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_8_0_X.

CalibCalorimetry/EcalLaserAnalyzer: disable object I/O (ClassDef)

It involves the following packages:

CalibCalorimetry/EcalLaserAnalyzer

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlt
Copy link
Contributor Author

davidlt commented Oct 27, 2015

Tested locally. Compiles fine for ROOT 6.02 and 6.04. Launching the tests.

@diguida
Copy link
Contributor

diguida commented Oct 27, 2015

+1
provided Jenkins agrees.
The classes involved are control classes not requiring I/O.

@davidlt no objections from AlCa side on a 76X back-port.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9232/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlt
Copy link
Contributor Author

davidlt commented Oct 27, 2015

This currently only affects ROOT 6.04 and 6.06. That's only for CMSSW_8_0_X. But I can make a PR for CMSSW_7_6_X.

@cmsbuild
Copy link
Contributor

+1
Tested at: f301c35
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12115/9227/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1
(no need for 76x I think)

cmsbuild added a commit that referenced this pull request Oct 27, 2015
@cmsbuild
Merge pull request #12115 from davidlt/fix-dict-root64-v2
2e43936 
CalibCalorimetry/EcalLaserAnalyzer: disable object I/O (ClassDef)
@cmsbuild cmsbuild merged commit 2e43936 into cms-sw:CMSSW_8_0_X Oct 27, 2015
@diguida
Copy link
Contributor

diguida commented Oct 27, 2015

@davidlange6 it is harmless and fixes a regression in ROOT.
I will sign the back-port, then we can decide about the inclusion...

@diguida diguida mentioned this pull request Oct 27, 2015
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: f301c35
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12115/9232/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12115/9227/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12115/9232/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-pending fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidlt @cmsbuild @diguida @davidlange6