HIN Jet DQM module version 3

[rkunnawa]

This is the updated HIN Jet DQM module v3, containing some bug fixes and new additions based on the PR #12002 which contains the centrality bin. We checked the matrix with the aforementioned PR merged. Once the Heavy Ion come up with a 75X version of that #12002, we will request a back port into 75X.
Thanks!

[cmsbuild]

A new Pull Request was created by @rkunnawa (Raghav Kunnawalkam Elayavalli) for CMSSW_7_6_X.

HIN Jet DQM module version 3

It involves the following packages:

DQMOffline/JetMET
Validation/RecoJets

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso, @TaiSakuma, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[diguida]

please test

[diguida]

@rkunnawa @smdogra the 75X back-port of #12002 is ready, together with GT: #12213

[diguida]

@franzoni @mmusich

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9390/console

[rkunnawa]

@diguida, thanks for telling me about the backport. I will prepare a PR for that now. I will test it with merging the #12213.

[cmsbuild]

+1
Tested at: 3dcc029
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12194/9390/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12194/9390/summary.html

[deguio]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9419/console

[cmsbuild]

Pull request #12194 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

[cmsbuild]

+1
Tested at: 2a042c7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12194/9419/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12194/9419/summary.html

[rkunnawa]

@deguio and @danduggan, this has been in hold for about a week now and we are requesting the dqm signature for this PR. Please let me know if you need any additional information.

Cheers
Raghav

[deguio]

ciao @rkunnawa
please submit to 80x as well.
I think the changes are fine even if the use of containers to hold monitor elements would make the code more readable and more maintainable.
in general please don't comment code. just remove the commented lines from both c++ and python.
thanks,
F.

[rkunnawa]

Hi @deguio, Im testing the PR for 80X at the moment with the matrix. In the meanwhile, I can remove the commented out statements to this PR and we can test this again.

[rkunnawa]

@deguio, ive created a new PR for 80X with the same Jet DQM code (with removing some of the commented out code) #12353.

[deguio]

ok thanks. I triggered the tests there.

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

I am cleaning up the 76x queue aside from things for analysis workflows. I'm closing this pull request, please make sure the PR is in 80x. Thanks!