HIN Jet DQM/Validation in 80X, with removing commented out code

[rkunnawa]

Latest HIN Jet DQM/Validation modules for 80X. Useful to test background subtracted jets and its composite structures.
Cheers
Raghav

[cmsbuild]

A new Pull Request was created by @rkunnawa (Raghav Kunnawalkam Elayavalli) for CMSSW_8_0_X.

HIN Jet DQM/Validation in 80X, with removing commented out code

It involves the following packages:

DQMOffline/JetMET
Validation/RecoJets

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso, @TaiSakuma, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[deguio]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9632/console

[deguio]

+1
provided it passes the tests
as commented in #12194 some improvement to the readibility/maintainability of the code could be implemented.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: dc142c0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12353/9632/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12353/9632/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[davidlange6]

@rkunnawa @deguio - looks like this pr has introduced problems in the 80x IBs. Could you have a look (I'm told the underlying problem is dereferencing null MonitorElements)

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc493/CMSSW_8_0_X_2015-11-15-1100/pyRelValMatrixLogs/run/140.1_QCD_Pt_80_120_13_HI+QCD_Pt_80_120_13_HIINPUT+DIGIHI+RECOHI+HARVESTHI/step3_QCD_Pt_80_120_13_HI+QCD_Pt_80_120_13_HIINPUT+DIGIHI+RECOHI+HARVESTHI.log

[rkunnawa]

Hi @davidlange6 and @deguio, Let me take a look now and get back to you guys. thanks for letting me know.

[rkunnawa]

Hi @davidlange6, i found the unused monitoring elements and removed them. I pushed it into this commit, but i dont see it here. Should i submit a new PR containing the bug fix?

[davidlange6]

yes, since this PR is merged, you need to make a new PR.
Thanks!

On Nov 17, 2015, at 10:10 AM, Raghav Kunnawalkam Elayavalli notifications@github.com wrote:

Hi @davidlange6, i found the unused monitoring elements and removed them. I pushed it into this commit, but i dont see it here. Should i submit a new PR containing the bug fix?

—
Reply to this email directly or view it on GitHub.

[rkunnawa]

@davidlange6
#12452 contains the necessary fix.
thanks!