Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tight mva value of HI initial step to be equal to highPurity mva value (80X version of #12223) #12231

Merged
merged 1 commit into from Nov 5, 2015

Conversation

istaslis
Copy link
Contributor

@istaslis istaslis commented Nov 2, 2015

80X version of PR #12223.
This PR changes mva value of 'tight' selection of HI initial step reconstruction. This is a minor fix to prevent confusion and it does not change the event content (because subsequent steps are dependent on 'highPurity', not 'tight' selection)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

A new Pull Request was created by @istaslis (Stas Lisniak) for CMSSW_8_0_X.

Set tight mva value of HI initial step to be equal to highPurity mva value (80X version of #12223)

It involves the following packages:

RecoHI/HiTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @dgulhan, @echapon, @yenjie, @kurtejung, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9418/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

-1

Tested at: 67e1b54
I found errors in the following addon tests:

cmsRun /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2015-11-01-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Nov 2 20:49:54 2015-date Mon Nov 2 20:32:29 2015 s - exit: 35072
cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Mon Nov 2 20:45:31 2015-date Mon Nov 2 20:36:20 2015 s - exit: 35072

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12231/9418/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
96658e0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12231/9418/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12231/9418/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9446/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 4, 2015

+1

For #12231 67e1b54

Adjusting the tight MVA value of the Heavy Ions initial step. There should be no change in monitored quantities. #12223 and #12230 are the 75X and 76X versions of this PR, and they have already been approved by Reco.

Jenkins tests against baseline CMSSW_8_0_X_2015-11-02-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 5, 2015
Set tight mva value of HI initial step to be equal to highPurity mva value (80X version of #12223)
@cmsbuild cmsbuild merged commit 21ac474 into cms-sw:CMSSW_8_0_X Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants