Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heavy ion relval tests #12303

Merged
merged 2 commits into from Nov 11, 2015
Merged

Fix heavy ion relval tests #12303

merged 2 commits into from Nov 11, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 6, 2015

These are bug fixes for the failures of relvals 300.0, 301.0, and 302.0 in 7_6_X and 8_0_X.
These are bug fixes, so they are being submitted to 7_6_X.
There are three parts to the fixes:

  1. Generalize the mixing module (mainly MixingWorker) to handle multiple labels at once for HepMCProduct, as the heavy ion smearer uses a smeared HepMCProduct from pileup to smear the unsmeared HepMCProduct from the signal. Do this so that the labels are not hard coded, but taken from the configuration files.
  2. Fix heavy ion specific configurations to use the correct labels.
  3. Fix one other config file ( SimMuon/GEMDigitizer/python/customizeGEMDigi.py) to properly handle backward compatibility.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2015

A new Pull Request was created by @wmtan for CMSSW_7_6_X.

Fix heavy ion relval tests

It involves the following packages:

GeneratorInterface/HiGenCommon
PhysicsTools/HepMCCandAlgos
SimGeneral/MixingModule
SimMuon/GEMDigitizer

@vciulli, @civanch, @covarell, @mdhildreth, @monttj, @cmsbuild, @thuer, @bendavid, @vadler, @govoni can you please review it and eventually sign? Thanks.
@cbaus, @mkirsano, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@wmtan
Copy link
Contributor Author

wmtan commented Nov 7, 2015

@yetkinyilmaz FYI, this fixes the HI relval tests.

@civanch
Copy link
Contributor

civanch commented Nov 7, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9509/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2015

@wmtan
Copy link
Contributor Author

wmtan commented Nov 8, 2015

While looking at this PR, I found a minor bug that would cause an incorrect LogInfo message to be issued. So, I updated this PR with a second commit to fix this bug.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2015

Pull request #12303 was updated. @vciulli, @civanch, @covarell, @mdhildreth, @monttj, @cmsbuild, @thuer, @bendavid, @vadler, @govoni can you please check and sign again.

@wmtan
Copy link
Contributor Author

wmtan commented Nov 8, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9513/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2015

@covarell
Copy link
Contributor

covarell commented Nov 8, 2015

+1

@civanch
Copy link
Contributor

civanch commented Nov 9, 2015

+1

@wmtan wmtan mentioned this pull request Nov 10, 2015
davidlange6 added a commit that referenced this pull request Nov 11, 2015
@davidlange6 davidlange6 merged commit 2301069 into cms-sw:CMSSW_7_6_X Nov 11, 2015
@wmtan wmtan deleted the FixHIRelvals branch November 16, 2015 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants