Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PackedCandidate restore old behavior #12367

Merged
merged 1 commit into from Nov 11, 2015
Merged

PackedCandidate restore old behavior #12367

merged 1 commit into from Nov 11, 2015

Conversation

davidlange6
Copy link
Contributor

restore desired behavior of keeping the packed info even if the pre-packed info is available to the job

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Nov 10, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_6_X.

PackedCandidate restore old behavior

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor Author

cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9643/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9644/console

@cmsbuild
Copy link
Contributor

-1

Tested at: ad2c19b
I found errors in the following unit tests:

---> test testDataFormatsPatCandidates had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12367/9644/summary.html

@davidlange6
Copy link
Contributor Author

cmsbuild, please test
errors seem to be das related - maybe its not so bad now.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9649/console

davidlange6 added a commit that referenced this pull request Nov 11, 2015
@davidlange6
Merge pull request #12367 from davidlange6/restorepacked
b99d8eb 
PackedCandidate restore old behavior
@davidlange6 davidlange6 merged commit b99d8eb into cms-sw:CMSSW_7_6_X Nov 11, 2015
@cmsbuild
Copy link
Contributor

-1

Tested at: ad2c19b
I found errors in the following unit tests:

---> test testDataFormatsPatCandidates had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12367/9649/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12367/9649/summary.html

This was referenced Nov 25, 2015
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-pending orp-pending pending-signatures tests-started
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidlange6 @cmsbuild