Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make HLTFilters global modules - part 1 #1240

Merged
merged 8 commits into from Nov 11, 2013

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 30, 2013

This is a work-in-progress to convert all HLTFilters into global modules.
As a first step, clean up most of the HLTFilters so that they do not modify their internal state during the call to hltFilter().

The only exception left is HLTLevel1GTSeed, which looks rather complicated to fix, and will be dealt in a subsequent pull request.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_0_X.

make HLTFilters global modules - step 0

It involves the following packages:

EventFilter/Cosmics
CaloOnlineTools/EcalTools
HLTrigger/HLTfilters
DQM/DTMonitorModule
RecoTracker/DeDx
HLTrigger/special
RecoTauTag/HLTProducers
HLTrigger/Muon
RecoEgamma/Examples
HLTrigger/Egamma
RecoEgamma/EgammaElectronAlgos
HLTrigger/HLTcore
HLTrigger/JetMET
DPGAnalysis/Skims
HLTrigger/btau

@perrotta, @smuzaffar, @thspeer, @vlimant, @demattia, @danduggan, @fwyzard, @emeschi, @rovere, @Martin-Grunewald, @franzoni, @nclopezo, @rcastello, @deguio, @slava77, @mommsen, @eliasron, @fabiocos can you please review it and eventually sign? Thanks.
@ghellwig, @gpetruc, @GiacomoSguazzoni, @rovere, @cerati this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@deguio
Copy link
Contributor

deguio commented Oct 31, 2013

+1

@ktf
Copy link
Contributor

ktf commented Oct 31, 2013

@fwyzard can you please rebase this?

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 31, 2013

rebased on top of CMSSW_7_0_X_2013-10-31-0200, hopefully I fixed all the errors that crept in

@cmsbuild
Copy link
Contributor

Pull request #1240 was updated. @perrotta, @thspeer, @vlimant, @demattia, @danduggan, @fwyzard, @emeschi, @rovere, @Martin-Grunewald, @franzoni, @nclopezo, @rcastello, @deguio, @slava77, @mommsen, @eliasron, @fabiocos can you please check and sign again.

@emeschi
Copy link
Contributor

emeschi commented Nov 1, 2013

+1

On Nov 1, 2013, at 12:37 AM, cmsbuild notifications@github.com wrote:

Pull request #1240 was updated. @perrotta, @thspeer, @vlimant, @demattia, @danduggan, @fwyzard, @emeschi, @rovere, @Martin-Grunewald, @franzoni, @nclopezo, @rcastello, @deguio, @slava77, @mommsen, @eliasron, @fabiocos can you please check and sign again.


Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2013

-1
When I ran the RelVals I found an error in the following worklfows:
401.0 step1

runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log
----- Begin Fatal Exception 01-Nov-2013 10:50:30 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mixGenPU'
   [2] Calling RootInputFileSequence::initFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd.ba.infn.it//store/relval/CMSSW_5_3_6-START53_V14/RelValProdMinBias/GEN-SIM-RAW/v2/00000/4677049F-042A-E211-8525-0026189438E8.root'
   Additional Info:
      [a] Input file root://eoscms//eos/cms/store/relval/CMSSW_5_3_6-START53_V14/RelValProdMinBias/GEN-SIM-RAW/v2/00000/4677049F-042A-E211-8525-0026189438E8.root?svcClass=default could not be opened.
Fallback Input file root://xrootd.ba.infn.it//store/relval/CMSSW_5_3_6-START53_V14/RelValProdMinBias/GEN-SIM-RAW/v2/00000/4677049F-042A-E211-8525-0026189438E8.root also could not be opened.
      [b] XrdClient::Open(name='root://xrootd.ba.infn.it//store/relval/CMSSW_5_3_6-START53_V14/RelValProdMinBias/GEN-SIM-RAW/v2/00000/4677049F-042A-E211-8525-0026189438E8.root', flags=0x10, permissions=0666) => error 'cannot obtain credentials for protocol: Secgsi: ErrParseBuffer: unknown CA: cannot verify server certificate: kXGS_init: unable to get protocol object.' (errno=3010)
      [c] Current server connection: root://xrootd.ba.infn.it:1094//store/relval/CMSSW_5_3_6-START53_V14/RelValProdMinBias/GEN-SIM-RAW/v2/00000/4677049F-042A-E211-8525-0026189438E8.root
----- End Fatal Exception -------------------------------------------------

4.22 step4

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step4_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
----- Begin Fatal Exception 01-Nov-2013 10:55:09 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd.ba.infn.it//store/data/Run2011A/Cosmics/RAW/v1/000/160/960/049F6443-8E53-E011-A943-003048F117EA.root'
   Additional Info:
      [a] Input file root://eoscms//eos/cms/store/data/Run2011A/Cosmics/RAW/v1/000/160/960/049F6443-8E53-E011-A943-003048F117EA.root?svcClass=default could not be opened.
Fallback Input file root://xrootd.ba.infn.it//store/data/Run2011A/Cosmics/RAW/v1/000/160/960/049F6443-8E53-E011-A943-003048F117EA.root also could not be opened.
      [b] XrdClient::Open(name='root://xrootd.ba.infn.it//store/data/Run2011A/Cosmics/RAW/v1/000/160/960/049F6443-8E53-E011-A943-003048F117EA.root', flags=0x10, permissions=0666) => error 'cannot obtain credentials for protocol: Secgsi: ErrParseBuffer: unknown CA: cannot verify server certificate: kXGS_init: unable to get protocol object.' (errno=3010)
      [c] Current server connection: root://xrootd.ba.infn.it:1094//store/data/Run2011A/Cosmics/RAW/v1/000/160/960/049F6443-8E53-E011-A943-003048F117EA.root
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1130/summary.html

@nclopezo
Copy link
Contributor

nclopezo commented Nov 1, 2013

this error seems to be unrelated, but Jenkins automatically reported it when the tests finished.

@thspeer
Copy link
Contributor

thspeer commented Nov 1, 2013

+1
Tested 5ab8caf in CMSSW_7_0_X_2013-11-01-0200-1240
No difference in reco as expected, based on reco script

@Martin-Grunewald
Copy link
Contributor

+1

2 similar comments
@deguio
Copy link
Contributor

deguio commented Nov 1, 2013

+1

@demattia
Copy link
Contributor

demattia commented Nov 1, 2013

+1

fwyzard added a commit to fwyzard/cmssw that referenced this pull request Nov 3, 2013
@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 3, 2013

this is included in #1303 , based on CMSSW_7_0_X_2013-11-03-1400, so it might be easier to merge directly #1303

@ktf ktf merged commit 5ab8caf into cms-sw:CMSSW_7_0_X Nov 11, 2013
@fwyzard fwyzard deleted the make_HLTFilters_global_modules branch November 12, 2013 15:14
aloeliger added a commit to aloeliger/cmssw that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants