New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Run2-hcx55 Changes to HO Calibration code due to Gobinda #12629
Conversation
A new Pull Request was created by @bsunanda for CMSSW_8_0_X. It involves the following packages: Calibration/HcalAlCaRecoProducers @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@cmsbuild Please test |
The tests are being triggered in jenkins. |
-1 ^ 28 warnings generated. >> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-30-2300/src/Calibration/HcalAlCaRecoProducers/plugins/AlCaIsoTracksFilter.cc >> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-30-2300/src/Calibration/HcalAlCaRecoProducers/plugins/PrescalerFHN.cc >> Compiling LCG dictionary: tmp/slc6_amd64_gcc493/src/Calibration/HcalCalibAlgos/src/CalibrationHcalCalibAlgos/a/CalibrationHcalCalibAlgos_xr.cc /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-30-2300/src/Calibration/HcalAlCaRecoProducers/src/AlCaHOCalibProducer.cc:154:11: error: unused variable 'nchnmx' [-Werror,-Wunused-const-variable] const int nchnmx = 10; ^ /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-30-2300/src/Calibration/HcalAlCaRecoProducers/src/AlCaHOCalibProducer.cc:157:11: error: unused variable 'nsigpk' [-Werror,-Wunused-const-variable] const int nsigpk = 7; ^ you can see the results of the tests here: |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
-1 ^ :155:1: note: expanded from here boost_concept_check903 ^ 28 warnings generated. /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-04-1100/src/Calibration/HcalAlCaRecoProducers/src/AlCaHOCalibProducer.cc:158:11: error: unused variable 'nstrbn' [-Werror,-Wunused-const-variable] const int nstrbn = 0; ^ /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-04-1100/src/Calibration/HcalAlCaRecoProducers/src/AlCaHOCalibProducer.cc:159:11: error: unused variable 'ntrgp_gm' [-Werror,-Wunused-const-variable] const int ntrgp_gm = 11; ^ you can see the results of the tests here: |
@cmsbuild Please test |
please test |
The tests are being triggered in jenkins. |
+1 @bsunanda thanks for the update (*) The GT used is: 80X_dataRun2_v2 conddb list 80X_dataRun2_v2 | grep AlCaReco which points to: https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideAlCaRecoTriggerBits |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@bsunanda - could you clarify why all of the BuildFile changes are needed? |
This package were developed by several people each adding requirements in the BuildFile. It became a bit messy to follow them and so I tried to put the things in some order so that any additional requirement in future can be visually easy to be put in. From: David Lange [notifications@github.com] @bsunandahttps://github.com/bsunanda - could you clarify why all of the BuildFile changes are needed? — |
+1 |
bsunanda:Run2-hcx55 Changes to HO Calibration code due to Gobinda
Changes to HO calibration code as now used