Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new GenFilter for use by HI photon team (71X) #12645

Merged

Conversation

harmonicoscillator
Copy link
Contributor

backport of #12510

This gen filter for Pythia8 is meant to mimic the older one used with Pyquen, which can be found here:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/GeneratorInterface/HiGenCommon/src/EcalGenEvtSelectorFrag.cc

@bi-ran has done some sanity checking between the old filter and new filter which can be found here:
https://twiki.cern.ch/twiki/pub/CMS/MITHIGAnalysis2015/MCFilters.pdf

We would like to include these filters in the 71X series to be used for HI MC pp reference-run production.

R. Alex Barbieri added 2 commits December 2, 2015 10:48
add HINEcalGenEvtSelector, based on pyquen version

(cherry picked from commit c88da8c)
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_1_X.

It involves the following packages:

GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@covarell
Copy link
Contributor

covarell commented Dec 2, 2015

Why is this needed in 7.1.X? Is it planned for use also in pp reference MC?

@harmonicoscillator
Copy link
Contributor Author

@covarell Yes, we want to use these for pp reference run MC.

@covarell
Copy link
Contributor

covarell commented Dec 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10100/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 3, 2015
Add new GenFilter for use by HI photon team (71X)
@cmsbuild cmsbuild merged commit 7fc42ea into cms-sw:CMSSW_7_1_X Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants