Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw on unrunnable schedule #12763

Merged
merged 1 commit into from Jan 8, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions FWCore/Framework/src/Schedule.cc
Expand Up @@ -1218,7 +1218,7 @@ namespace edm {
}
}
if(nPathDependencyOnly < 2) {
reportError(tempStack,index,iGraph);
throwOnError(tempStack,index,iGraph);
}
}
private:
Expand All @@ -1236,9 +1236,9 @@ namespace edm {
}

void
reportError(std::vector<Edge>const& iEdges,
boost::property_map<Graph, boost::vertex_index_t>::type const& iIndex,
Graph const& iGraph) const {
throwOnError(std::vector<Edge>const& iEdges,
boost::property_map<Graph, boost::vertex_index_t>::type const& iIndex,
Graph const& iGraph) const {
std::stringstream oStream;
oStream <<"Module run order problem found: \n";
bool first_edge = true;
Expand Down Expand Up @@ -1270,7 +1270,8 @@ namespace edm {
oStream<<"\n Running in the threaded framework would lead to indeterminate results."
"\n Please change order of modules in mentioned Path(s) to avoid inconsistent module ordering.";

LogError("UnrunnableSchedule")<<oStream.str();
throw Exception(errors::ScheduleExecutionFailure, "Unrunnable schedule\n")
<< oStream.str() << "\n";
}

EdgeToPathMap const& m_edgeToPathMap;
Expand Down