Alignment filters 80X #12776

ghellwig · 2015-12-14T13:41:58Z

Tools to streamline the alignment work-flow and the corresponding validation.
These tools have been presented in
https://indico.cern.ch/event/442133/session/0/contribution/4/attachments/1203128/1751921/talk.pdf

Implemented as EDFilter that checks the SiStripLatencyRcd.

cmsbuild · 2015-12-14T13:42:17Z

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_8_0_X.

It involves the following packages:

Alignment/CommonAlignment

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @pakhotin, @mmusich, @tlampen this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

mmusich · 2015-12-15T10:25:53Z

please test

cmsbuild · 2015-12-15T10:26:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10297/console

mmusich · 2015-12-15T10:29:19Z

Alignment/CommonAlignment/plugins/MagneticFieldFilter.cc

+float
+MagneticFieldFilter::currentToField(const float& current) const {
+  return 2.084287e-04 * current + 1.704418e-02;
+}


@ghellwig magic numbers, please define them as const and clarify how they are extracted

You mean, I need to put the coefficients as constant data members with a comment where they come from?
It is in principle written in the documentation at the top of the code.

ok, I'll add these numbers as constants and will also update the backports of this PR.

cmsbuild · 2015-12-15T12:01:55Z

+1
Tested at: 1e3a5c1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12776/10297/summary.html

cmsbuild · 2015-12-15T13:08:18Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12776/10297/summary.html

Includes an (approximate) EDFilter and a script to create JSON files according to the content of the run registry.

cmsbuild · 2015-12-15T13:35:24Z

Pull request #12776 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

ghellwig · 2015-12-15T13:37:24Z

Hi Marco,
I updated the branch. Hope you are happy with the changes.
-Gregor

mmusich · 2015-12-15T13:39:13Z

@ghellwig thanks!

mmusich · 2015-12-15T13:39:18Z

please test

cmsbuild · 2015-12-15T13:39:33Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10304/console

cmsbuild · 2015-12-15T15:13:02Z

+1
Tested at: 5524b9a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12776/10304/summary.html

mmusich · 2015-12-15T15:46:22Z

+1
added two plugins to filter b-on/b-off data and SiStrip APV modes

cmsbuild · 2015-12-15T15:46:40Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2015-12-15T17:47:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12776/10304/summary.html

davidlange6 · 2015-12-16T01:13:40Z

+1

Alignment filters 80X

Alignment filters 75X (Backport of #12776)

Alignment filters 76X (Backport of #12776)

Alignment filters 74X (Backport of #12776)

Added APV mode filter.

ffc82cb

Implemented as EDFilter that checks the SiStripLatencyRcd.

cmsbuild added this to the Next CMSSW_8_0_X milestone Dec 14, 2015

cmsbuild added alca-pending pending-signatures tests-pending orp-pending comparison-pending labels Dec 14, 2015

This was referenced Dec 14, 2015

Alignment filters 76X (Backport of #12776) #12777

Closed

Alignment filters 76X (Backport of #12776) #12778

Merged

Alignment filters 75X (Backport of #12776) #12779

Merged

Alignment filters 74X (Backport of #12776) #12780

Merged

cmsbuild added tests-started and removed tests-pending labels Dec 15, 2015

mmusich reviewed Dec 15, 2015
View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Dec 15, 2015

cmsbuild added comparison-available and removed comparison-pending labels Dec 15, 2015

Added magnetic field filter tools.

5524b9a

Includes an (approximate) EDFilter and a script to create JSON files according to the content of the run registry.

ghellwig force-pushed the alignment-filters_80X branch from 1e3a5c1 to 5524b9a Compare December 15, 2015 13:34

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Dec 15, 2015

cmsbuild added tests-started and removed tests-pending labels Dec 15, 2015

cmsbuild added tests-approved and removed tests-started labels Dec 15, 2015

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Dec 15, 2015

cmsbuild added comparison-available and removed comparison-pending labels Dec 15, 2015

cmsbuild added orp-approved and removed orp-pending labels Dec 16, 2015

cmsbuild added a commit that referenced this pull request Dec 16, 2015

Merge pull request #12776 from ghellwig/alignment-filters_80X

f5b1814

Alignment filters 80X

cmsbuild merged commit f5b1814 into cms-sw:CMSSW_8_0_X Dec 16, 2015

ghellwig deleted the alignment-filters_80X branch December 16, 2015 09:22

cmsbuild added a commit that referenced this pull request Jan 5, 2016

Merge pull request #12779 from ghellwig/alignment-filters_75X

0713043

Alignment filters 75X (Backport of #12776)

cmsbuild added a commit that referenced this pull request Jan 5, 2016

Merge pull request #12778 from ghellwig/alignment-filters_76X

7d974d2

Alignment filters 76X (Backport of #12776)

cmsbuild added a commit that referenced this pull request Jan 5, 2016

Merge pull request #12780 from ghellwig/alignment-filters_74X

b7da517

Alignment filters 74X (Backport of #12776)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alignment filters 80X #12776

Alignment filters 80X #12776

ghellwig commented Dec 14, 2015

cmsbuild commented Dec 14, 2015

mmusich commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

mmusich Dec 15, 2015

ghellwig Dec 15, 2015

mmusich Dec 15, 2015

ghellwig Dec 15, 2015

mmusich Dec 15, 2015

cmsbuild commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

ghellwig commented Dec 15, 2015

mmusich commented Dec 15, 2015

mmusich commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

mmusich commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

davidlange6 commented Dec 16, 2015

Alignment filters 80X #12776

Alignment filters 80X #12776

Conversation

ghellwig commented Dec 14, 2015

cmsbuild commented Dec 14, 2015

mmusich commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

mmusich Dec 15, 2015

Choose a reason for hiding this comment

ghellwig Dec 15, 2015

Choose a reason for hiding this comment

mmusich Dec 15, 2015

Choose a reason for hiding this comment

ghellwig Dec 15, 2015

Choose a reason for hiding this comment

mmusich Dec 15, 2015

Choose a reason for hiding this comment

cmsbuild commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

ghellwig commented Dec 15, 2015

mmusich commented Dec 15, 2015

mmusich commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

mmusich commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

davidlange6 commented Dec 16, 2015