Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment filters 76X (Backport of #12776) #12778

Merged
merged 2 commits into from Jan 5, 2016

Conversation

ghellwig
Copy link

Tools to streamline the alignment work-flow and the corresponding validation.
These tools have been presented in
https://indico.cern.ch/event/442133/session/0/contribution/4/attachments/1203128/1751921/talk.pdf

Backport of #12776

Implemented as EDFilter that checks the SiStripLatencyRcd.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_7_6_X.

It involves the following packages:

Alignment/CommonAlignment

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @pakhotin, @mmusich, @tlampen this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@mmusich
Copy link
Contributor

mmusich commented Dec 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10296/console

@cmsbuild
Copy link
Contributor

Includes an (approximate) EDFilter and a script to create JSON files according
to the content of the run registry.
@cmsbuild
Copy link
Contributor

Pull request #12778 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Dec 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10305/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Dec 16, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 5, 2016
@cmsbuild cmsbuild merged commit 7d974d2 into cms-sw:CMSSW_7_6_X Jan 5, 2016
@ghellwig ghellwig deleted the alignment-filters_76X branch January 27, 2016 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants